Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge branch 'main' into main" #8622

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Revert "Merge branch 'main' into main" #8622

merged 1 commit into from
Sep 12, 2023

Conversation

leahwicz
Copy link
Contributor

This reverts commit c93cba4, reversing changes made to 9716690.

Problem

I went to sync my personal fork that I test with and somehow merged changes into main here. This is the problematic PR that did it which was in my repo leahwicz#69

Solution

Do a revert

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX

This reverts commit c93cba4, reversing
changes made to 9716690.
@leahwicz leahwicz requested a review from a team as a code owner September 12, 2023 01:55
@leahwicz leahwicz requested review from emmyoop and aranke and removed request for a team September 12, 2023 01:55
@cla-bot cla-bot bot added the cla:yes label Sep 12, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.03% ⚠️

Comparison is base (c93cba4) 86.59% compared to head (2477751) 86.56%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8622      +/-   ##
==========================================
- Coverage   86.59%   86.56%   -0.03%     
==========================================
  Files         174      174              
  Lines       25594    25594              
==========================================
- Hits        22162    22155       -7     
- Misses       3432     3439       +7     
Flag Coverage Δ
integration 83.35% <ø> (-0.03%) ⬇️
unit 65.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mikealfare mikealfare added the Skip Changelog Skips GHA to check for changelog file label Sep 12, 2023
@leahwicz leahwicz merged commit ad04012 into main Sep 12, 2023
@leahwicz leahwicz deleted the leahwicz/revertSync branch September 12, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants