remove top level meta attribute from SemanticModels

[emmyoop]

related to #8511

Problem

meta is a top level attribute in #8754 but doesn't need to be

Solution

Modify to only allow meta under the config key.

Checklist

• I have read the contributing guide and understand what's expected of me
• I have run this code in development and it appears to resolve the stated issue
• This PR includes tests, or tests are not required/relevant for this PR
• This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
• This PR includes type annotations for new and modified functions

[codecov]

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (eac13e3) 86.50% compared to head (1fff2ee) 85.34%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8766      +/-   ##
==========================================
- Coverage   86.50%   85.34%   -1.17%     
==========================================
  Files         176      176              
  Lines       25825    25821       -4     
==========================================
- Hits        22341    22038     -303     
- Misses       3484     3783     +299     

Flag	Coverage Δ
integration	81.99% <ø> (-1.29%)	⬇️
unit	65.12% <ø> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
core/dbt/contracts/graph/nodes.py	93.52% <ø> (-1.58%)	⬇️
core/dbt/contracts/graph/unparsed.py	93.51% <ø> (-0.02%)	⬇️
core/dbt/parser/schema_yaml_readers.py	91.91% <ø> (-0.07%)	⬇️

... and 35 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[emmyoop]

Code coverage went down but all I did was remove code.

[QMalcolm]

🚀 Looks great! Sorry about the thrash 🙃

[emmyoop]

@QMalcolm it was a good question and the code is a tiny bit cleaner now! Worth it.

[dbeatty10]

The current docs for the meta config says the following:

Depending on the resource you're configuring, meta may be available within the config property, or as a top-level key. (For backwards compatibility, meta is always supported as a top-level key, though without the capabilities of config inheritance.)

Since this is no longer accurate, I'll update it here to something like the following:

Depending on the resource you're configuring, meta may be available within the config property, and/or as a top-level key. (For backwards compatibility, meta is often (but not always) supported as a top-level key, though without the capabilities of config inheritance.)