Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncaught exception for group updates #8792

Merged
merged 8 commits into from
Oct 10, 2023
Merged

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Oct 6, 2023

resolves #8371

Problem

Uncaught exception when a group is updated when a model is also modified.

Solution

Prevent the exception

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Oct 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (d912654) 86.62% compared to head (c7c4d4a) 86.43%.
Report is 37 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8792      +/-   ##
==========================================
- Coverage   86.62%   86.43%   -0.19%     
==========================================
  Files         176      176              
  Lines       25663    26029     +366     
==========================================
+ Hits        22230    22499     +269     
- Misses       3433     3530      +97     
Flag Coverage Δ
integration 83.23% <100.00%> (-0.21%) ⬇️
unit 64.84% <0.00%> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/dbt/contracts/graph/manifest.py 93.85% <100.00%> (+<0.01%) ⬆️

... and 45 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emmyoop emmyoop marked this pull request as ready for review October 10, 2023 19:37
@emmyoop emmyoop requested a review from a team as a code owner October 10, 2023 19:37
@emmyoop emmyoop requested a review from QMalcolm October 10, 2023 19:37
@emmyoop emmyoop merged commit 4f9bd0c into main Oct 10, 2023
49 of 50 checks passed
@emmyoop emmyoop deleted the er/8371/updated-groups branch October 10, 2023 20:37
github-actions bot pushed a commit that referenced this pull request Oct 10, 2023
* add test

* write test

* fix test

* updating test

* add clean

* cleanup

* more tests, fix comment

* add new test, move fixtures

(cherry picked from commit 4f9bd0c)
github-actions bot pushed a commit that referenced this pull request Oct 10, 2023
* add test

* write test

* fix test

* updating test

* add clean

* cleanup

* more tests, fix comment

* add new test, move fixtures

(cherry picked from commit 4f9bd0c)
emmyoop added a commit that referenced this pull request Oct 10, 2023
* add test

* write test

* fix test

* updating test

* add clean

* cleanup

* more tests, fix comment

* add new test, move fixtures

(cherry picked from commit 4f9bd0c)

Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>
emmyoop added a commit that referenced this pull request Oct 10, 2023
* add test

* write test

* fix test

* updating test

* add clean

* cleanup

* more tests, fix comment

* add new test, move fixtures

(cherry picked from commit 4f9bd0c)

Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-2963] [Bug] CI breaking when a group is changed
2 participants