-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix uncaught exception for group updates #8792
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8792 +/- ##
==========================================
- Coverage 86.62% 86.43% -0.19%
==========================================
Files 176 176
Lines 25663 26029 +366
==========================================
+ Hits 22230 22499 +269
- Misses 3433 3530 +97
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
* add test * write test * fix test * updating test * add clean * cleanup * more tests, fix comment * add new test, move fixtures (cherry picked from commit 4f9bd0c)
* add test * write test * fix test * updating test * add clean * cleanup * more tests, fix comment * add new test, move fixtures (cherry picked from commit 4f9bd0c)
resolves #8371
Problem
Uncaught exception when a group is updated when a model is also modified.
Solution
Prevent the exception
Checklist