[Backport 1.7.latest] Fix partial parsing issue not working for changing semantic model name #8878

github-actions · 2023-10-23T17:29:00Z

Backport 35f46da from #8865.

#8865) * fix * test * changelog (cherry picked from commit 35f46da)

codecov · 2023-10-23T23:16:58Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1baebb4) 86.36% compared to head (0150f24) 86.31%.

Additional details and impacted files

@@              Coverage Diff               @@
##           1.7.latest    #8878      +/-   ##
==============================================
- Coverage       86.36%   86.31%   -0.05%     
==============================================
  Files             177      177              
  Lines           26383    26385       +2     
==============================================
- Hits            22786    22775      -11     
- Misses           3597     3610      +13

Flag	Coverage Δ
integration	`83.10% <100.00%> (-0.13%)`	⬇️
unit	`64.58% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
core/dbt/parser/partial.py	`93.62% <100.00%> (+0.30%)`	⬆️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

QMalcolm

Thanks for fixing this! ❤️

Fix partial parsing issue not working for changing semantic model name (

0150f24

#8865) * fix * test * changelog (cherry picked from commit 35f46da)

github-actions bot requested a review from a team as a code owner October 23, 2023 17:29

github-actions bot requested a review from QMalcolm October 23, 2023 17:29

cla-bot bot added the cla:yes label Oct 23, 2023

ChenyuLInx closed this Oct 23, 2023

ChenyuLInx reopened this Oct 23, 2023

graciegoheen approved these changes Oct 24, 2023

View reviewed changes

ChenyuLInx closed this Oct 24, 2023

ChenyuLInx reopened this Oct 24, 2023

QMalcolm approved these changes Oct 24, 2023

View reviewed changes

ChenyuLInx merged commit ced70d5 into 1.7.latest Oct 25, 2023
103 checks passed

ChenyuLInx deleted the backport-8865-to-1.7.latest branch October 25, 2023 18:23

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Backport 1.7.latest] Fix partial parsing issue not working for changing semantic model name #8878

[Backport 1.7.latest] Fix partial parsing issue not working for changing semantic model name #8878

github-actions bot commented Oct 23, 2023

codecov bot commented Oct 23, 2023 •

edited

Loading

QMalcolm left a comment

[Backport 1.7.latest] Fix partial parsing issue not working for changing semantic model name #8878

[Backport 1.7.latest] Fix partial parsing issue not working for changing semantic model name #8878

Conversation

github-actions bot commented Oct 23, 2023

codecov bot commented Oct 23, 2023 • edited Loading

Codecov Report

QMalcolm left a comment

Choose a reason for hiding this comment

codecov bot commented Oct 23, 2023 •

edited

Loading