Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix partial parsing issue not working for changing semantic model name #8865

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

ChenyuLInx
Copy link
Contributor

@ChenyuLInx ChenyuLInx commented Oct 16, 2023

resolves #8859

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@cla-bot cla-bot bot added the cla:yes label Oct 16, 2023
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (efa6339) 86.35% compared to head (b0fa402) 86.36%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8865   +/-   ##
=======================================
  Coverage   86.35%   86.36%           
=======================================
  Files         177      177           
  Lines       26383    26385    +2     
=======================================
+ Hits        22784    22787    +3     
+ Misses       3599     3598    -1     
Flag Coverage Δ
integration 83.20% <100.00%> (-0.02%) ⬇️
unit 64.58% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
core/dbt/parser/partial.py 93.62% <100.00%> (+0.30%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ChenyuLInx ChenyuLInx marked this pull request as ready for review October 16, 2023 22:43
@ChenyuLInx ChenyuLInx requested a review from a team as a code owner October 16, 2023 22:43
@ChenyuLInx ChenyuLInx requested a review from gshank October 16, 2023 22:43
@ChenyuLInx ChenyuLInx merged commit 35f46da into main Oct 23, 2023
55 checks passed
@ChenyuLInx ChenyuLInx deleted the cl/fix_semantic_model_partial_parse branch October 23, 2023 16:56
@dbeatty10
Copy link
Contributor

🎉

We should check if this also resolves #8872

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants