[ADAP-631] Convert Target_lag to str type to add Downstream option #732
Conversation
Added a test following the current method of alter and seeing if a run is successful till we find a way to check the |
There was a problem hiding this comment.
I think this got caught in here accidentally.
There was a problem hiding this comment.
yeah forgot one for the #727 so added it here instead of trying to do a entire revert, and add since we don't tie the pr to the changelog anymore and this pr was reliant on that pr to pass
.
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-732-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 73ea41ae5d29add8b448c1b9c5fdb84b4a580450
# Push it to GitHub
git push --set-upstream origin backport-732-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latestThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-732-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 73ea41ae5d29add8b448c1b9c5fdb84b4a580450
# Push it to GitHub
git push --set-upstream origin backport-732-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latestThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-732-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 73ea41ae5d29add8b448c1b9c5fdb84b4a580450
# Push it to GitHub
git push --set-upstream origin backport-732-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latestThen, create a pull request where the |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-732-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 73ea41ae5d29add8b448c1b9c5fdb84b4a580450
# Push it to GitHub
git push --set-upstream origin backport-732-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latestThen, create a pull request where the |
…bt-labs#732) * update RELEASE_BRANCH env * initial push for ADAP-631 to convert target_lag to a str type * readd SnowflakeDynamicTableTargetLagConfigChange class as part of dynamic_table.py * pull in ADAP-774 and add changelog * add missing changelog entry for pr 727 * update to main, and add basic test case for passing downstream via alter
resolves #
docs dbt-labs/docs.getdbt.com/#
Problem
We need to allow for all target lags variations that Snowflake accepts. Variations include:
Solution
change expected type to str
TODO:
downstreamoption.Checklist