Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAP-631] Convert Target_lag to str type to add Downstream option #732

Merged
merged 35 commits into from
Aug 14, 2023
Merged
Show file tree
Hide file tree
Changes from 30 commits
Commits
Show all changes
35 commits
Select commit Hold shift + click to select a range
032b5b5
update RELEASE_BRANCH env
McKnight-42 Apr 14, 2023
16470c2
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Apr 25, 2023
4c475f1
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 May 25, 2023
81d5d5d
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 May 26, 2023
f1d8078
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 May 30, 2023
2773177
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 May 30, 2023
77a2b66
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 May 30, 2023
d9d3d2d
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Jun 1, 2023
a51efc2
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Jun 2, 2023
df68367
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Jun 12, 2023
d9ab1ac
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Jun 14, 2023
942473f
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Jun 16, 2023
f579bf9
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Jun 26, 2023
eb89108
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Jun 28, 2023
2213e2c
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Jun 29, 2023
a97950b
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Jul 7, 2023
f5d4ebf
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Jul 11, 2023
701a9ce
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Jul 14, 2023
b462076
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Jul 17, 2023
f57b14c
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Jul 18, 2023
06083ab
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Jul 19, 2023
508e7b2
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Jul 31, 2023
26b035c
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Aug 1, 2023
2f311e2
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Aug 3, 2023
fca0498
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Aug 4, 2023
cbb1ed2
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake
McKnight-42 Aug 8, 2023
18da2c6
initial push for ADAP-631 to convert target_lag to a str type
McKnight-42 Aug 9, 2023
d0307b5
readd SnowflakeDynamicTableTargetLagConfigChange class as part of dyn…
McKnight-42 Aug 9, 2023
e08d025
pull in ADAP-774
McKnight-42 Aug 10, 2023
207a36b
pull in ADAP-774 and add changelog
McKnight-42 Aug 10, 2023
393a21f
add missing changelog entry for pr 727
McKnight-42 Aug 10, 2023
5df0d46
Merge branch 'main' into mcknight/ADAP-631
McKnight-42 Aug 11, 2023
c8d872a
Merge branch 'main' of gist.github.com:dbt-labs/dbt-snowflake into mc…
McKnight-42 Aug 14, 2023
0f83b8a
update to main, and add basic test case for passing downstream via alter
McKnight-42 Aug 14, 2023
7f1034c
Merge branch 'mcknight/ADAP-631' of gist.github.com:dbt-labs/dbt-snow…
McKnight-42 Aug 14, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .changes/unreleased/Fixes-20230810-154613.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
kind: Fixes
body: change target_lag type to allow for downstream as a option
time: 2023-08-10T15:46:13.896057-05:00
custom:
Author: McKnight-42
Issue: "734"
6 changes: 1 addition & 5 deletions dbt/adapters/snowflake/relation_configs/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,10 @@
SnowflakeDynamicTableConfig,
SnowflakeDynamicTableConfigChangeset,
SnowflakeDynamicTableWarehouseConfigChange,
SnowflakeDynamicTableTargetLagConfigChange,
)
from dbt.adapters.snowflake.relation_configs.policies import (
SnowflakeIncludePolicy,
SnowflakeQuotePolicy,
SnowflakeRelationType,
)
from dbt.adapters.snowflake.relation_configs.target_lag import (
SnowflakeDynamicTableTargetLagConfig,
SnowflakeDynamicTableTargetLagConfigChange,
SnowflakeDynamicTableTargetLagPeriod,
)
37 changes: 13 additions & 24 deletions dbt/adapters/snowflake/relation_configs/dynamic_table.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,6 @@
from dbt.contracts.relation import ComponentName

from dbt.adapters.snowflake.relation_configs.base import SnowflakeRelationConfigBase
from dbt.adapters.snowflake.relation_configs.target_lag import (
SnowflakeDynamicTableTargetLagConfig,
SnowflakeDynamicTableTargetLagConfigChange,
)


@dataclass(frozen=True, eq=True, unsafe_hash=True)
Expand All @@ -32,7 +28,7 @@ class SnowflakeDynamicTableConfig(SnowflakeRelationConfigBase):
schema_name: str
database_name: str
query: str
target_lag: SnowflakeDynamicTableTargetLagConfig
target_lag: str
snowflake_warehouse: str

@classmethod
Expand All @@ -44,14 +40,10 @@ def from_dict(cls, config_dict) -> "SnowflakeDynamicTableConfig":
ComponentName.Database, config_dict.get("database_name")
),
"query": config_dict.get("query"),
"target_lag": config_dict.get("target_lag"),
"snowflake_warehouse": config_dict.get("snowflake_warehouse"),
}

if target_lag := config_dict.get("target_lag"):
kwargs_dict.update(
{"target_lag": SnowflakeDynamicTableTargetLagConfig.from_dict(target_lag)}
)

dynamic_table: "SnowflakeDynamicTableConfig" = super().from_dict(kwargs_dict) # type: ignore
return dynamic_table

Expand All @@ -62,14 +54,10 @@ def parse_model_node(cls, model_node: ModelNode) -> dict:
"schema_name": model_node.schema,
"database_name": model_node.database,
"query": model_node.compiled_code,
"target_lag": model_node.config.extra.get("target_lag"),
"snowflake_warehouse": model_node.config.extra.get("snowflake_warehouse"),
}

if model_node.config.extra.get("target_lag"):
config_dict.update(
{"target_lag": SnowflakeDynamicTableTargetLagConfig.parse_model_node(model_node)}
)

return config_dict

@classmethod
Expand All @@ -81,21 +69,22 @@ def parse_relation_results(cls, relation_results: RelationResults) -> dict:
"schema_name": dynamic_table.get("schema_name"),
"database_name": dynamic_table.get("database_name"),
"query": dynamic_table.get("text"),
"target_lag": dynamic_table.get("target_lag"),
"snowflake_warehouse": dynamic_table.get("warehouse"),
}

if dynamic_table.get("target_lag"):
config_dict.update(
{
"target_lag": SnowflakeDynamicTableTargetLagConfig.parse_relation_results(
dynamic_table
)
}
)

return config_dict


@dataclass(frozen=True, eq=True, unsafe_hash=True)
class SnowflakeDynamicTableTargetLagConfigChange(RelationConfigChange):
McKnight-42 marked this conversation as resolved.
Show resolved Hide resolved
mikealfare marked this conversation as resolved.
Show resolved Hide resolved
context: Optional[str] = None

@property
def requires_full_refresh(self) -> bool:
return False


@dataclass(frozen=True, eq=True, unsafe_hash=True)
class SnowflakeDynamicTableWarehouseConfigChange(RelationConfigChange):
context: Optional[str] = None
Expand Down
111 changes: 0 additions & 111 deletions dbt/adapters/snowflake/relation_configs/target_lag.py

This file was deleted.

Loading