Supports new error messages. #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtcohen6
added
the
ready_for_review
McKnight-42
reviewed
Nov 28, 2022
McKnight-42
reviewed
Nov 28, 2022
McKnight-42
approved these changes
Nov 28, 2022
|
@ueshin seems the change you made for the tuple may of introduced something |
McKnight-42
approved these changes
Nov 29, 2022
McKnight-42
pushed a commit
that referenced
this pull request
Nov 29, 2022
* Supports new error messages. * changie * tuple * fix. * suggestion.
6 tasks
McKnight-42
pushed a commit
that referenced
this pull request
Nov 29, 2022
6 tasks
McKnight-42
pushed a commit
that referenced
this pull request
Nov 29, 2022
6 tasks
McKnight-42
pushed a commit
that referenced
this pull request
Nov 29, 2022
6 tasks
McKnight-42
added a commit
that referenced
this pull request
Dec 2, 2022
McKnight-42
added a commit
that referenced
this pull request
Dec 2, 2022
McKnight-42
added a commit
that referenced
this pull request
Dec 2, 2022
* manual backport/modifcation of #520 to mergable to 1.1.latest * returning to older style call in logic Co-authored-by: Takuya UESHIN <ueshin@databricks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #515
Description
Supports new error messages.
In
SparkAdapter.get_columns_in_relation, it checks the error message when the specified table or view doesn't exist:dbt-spark/dbt/adapters/spark/impl.py
Line 223 in c87b6b2
but, Spark will change the error message in the future release (apache/spark#37887), which causes the function to raise the
dbt.exceptions.RuntimeExceptioninstead of returning an empty list.The function should also check whether the error message contains
[TABLE_OR_VIEW_NOT_FOUND]or not.Checklist
changie newto create a changelog entry