Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports new error messages. #520

Merged
merged 5 commits into from
Nov 29, 2022
Merged

Supports new error messages. #520

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
689bbe6
Supports new error messages.
ueshin Nov 16, 2022
ba67a07
changie
ueshin Nov 16, 2022
bc2a6d1
tuple
ueshin Nov 28, 2022
07bad99
fix.
ueshin Nov 28, 2022
1152e42
suggestion.
ueshin Nov 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changes/unreleased/Fixes-20221116-234601.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
kind: Fixes
body: Support new error messages in the future Spark.
time: 2022-11-16T23:46:01.899921861Z
custom:
Author: ueshin
Issue: "515"
PR: "520"
9 changes: 8 additions & 1 deletion dbt/adapters/spark/impl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,12 @@
KEY_TABLE_OWNER = "Owner"
KEY_TABLE_STATISTICS = "Statistics"

TABLE_OR_VIEW_NOT_FOUND_MESSAGES = (
"[TABLE_OR_VIEW_NOT_FOUND]",
"Table or view not found",
"NoSuchTableException",
)


@dataclass
class SparkConfig(AdapterConfig):
Expand Down Expand Up @@ -220,7 +226,8 @@ def get_columns_in_relation(self, relation: Relation) -> List[SparkColumn]:
# spark would throw error when table doesn't exist, where other
# CDW would just return and empty list, normalizing the behavior here
errmsg = getattr(e, "msg", "")
if "Table or view not found" in errmsg or "NoSuchTableException" in errmsg:
found_msgs = (msg in errmsg for msg in TABLE_OR_VIEW_NOT_FOUND_MESSAGES)
if any(found_msgs):
pass
else:
raise e
Expand Down