fix SparkConnectionManager.data_type_code_to_name for pyodbc

.changes/unreleased/Fixes-20230303-200542.yaml

@@ -0,0 +1,6 @@
+kind: Fixes
+body: 'Fix pyodbc type_code -> data_type conversion '
+time: 2023-03-03T20:05:42.400255-05:00
+custom:
+  Author: michelleark
+  Issue: "665"

dbt/adapters/spark/connections.py

@@ -25,7 +25,7 @@
 
 from hologram.helpers import StrEnum
 from dataclasses import dataclass, field
-from typing import Any, Dict, Optional
+from typing import Any, Dict, Optional, Union
 
 try:
     from thrift.transport.TSSLSocket import TSSLSocket
@@ -493,8 +493,17 @@ def open(cls, connection):
         return connection
 
     @classmethod
-    def data_type_code_to_name(cls, type_code: str) -> str:
-        return type_code
+    def data_type_code_to_name(cls, type_code: Union[type, str]) -> str:  # type: ignore
+        """
+        :param Union[type, str] type_code: The sql to execute.
+            * type_code is a python type (!) in pyodbc https://github.com/mkleehammer/pyodbc/wiki/Cursor#description, and a string for other spark runtimes.
+            * ignoring the type annotation on the signature for this adapter instead of updating the base class because this feels like a really special case.
+        :return: stringified the cursor type_code
+        :rtype: str
+        """
+        if isinstance(type_code, str):
+            return type_code
+        return type_code.__name__.upper()
 
 
 def build_ssl_transport(host, port, username, auth, kerberos_service_name, password=None):

tests/functional/adapter/test_constraints.py

@@ -4,10 +4,16 @@
     BaseConstraintsColumnsEqual,
     BaseConstraintsRuntimeEnforcement
 )
+from dbt.tests.adapter.constraints.fixtures import (
+    my_model_sql,
+    my_model_wrong_order_sql,
+    my_model_wrong_name_sql,
+    model_schema_yml,
+)
 
 # constraints are enforced via 'alter' statements that run after table creation
 _expected_sql_spark = """
-create or replace table {0}  
+create or replace table {0}
     using delta
     as
 
@@ -17,20 +23,107 @@
     cast('2019-01-01' as date) as date_day
 """
 
-@pytest.mark.skip_profile('spark_session', 'apache_spark')
-class TestSparkConstraintsColumnsEqual(BaseConstraintsColumnsEqual):
-    pass
+# Different on Spark:
+# - does not support a data type named 'text' (TODO handle this in the base test classes using string_type
+constraints_yml = model_schema_yml.replace("text", "string").replace("primary key", "")
+
+
+@pytest.mark.skip_profile('spark_session', 'apache_spark', 'databricks_http_cluster')
+class TestSparkConstraintsColumnsEqualPyodbc(BaseConstraintsColumnsEqual):
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {
+            "my_model_wrong_order.sql": my_model_wrong_order_sql,
+            "my_model_wrong_name.sql": my_model_wrong_name_sql,
+            "constraints_schema.yml": constraints_yml,
+        }
+
+    @pytest.fixture
+    def string_type(self):
+        return "STR"
+
+    @pytest.fixture
+    def int_type(self):
+        return "INT"
+
+    @pytest.fixture
+    def schema_int_type(self):
+        return "INT"
+
+    @pytest.fixture
+    def data_types(self, int_type, schema_int_type, string_type):
+        # sql_column_value, schema_data_type, error_data_type
+        return [
+            # TODO: the int type is tricky to test in test__constraints_wrong_column_data_type without a schema_string_type to override.
+            # uncomment the line below once https://github.com/dbt-labs/dbt-core/issues/7121 is resolved
+            # ['1', schema_int_type, int_type],
+            ['"1"', "string", string_type],
+            ["true", "boolean", "BOOL"],
+            ['array("1","2","3")', "string", string_type],
+            ['array(1,2,3)', "string", string_type],
+            ["6.45", "decimal", "DECIMAL"],
+            # TODO: test__constraints_correct_column_data_type isn't able to run the following statements in create table statements with pyodbc
+            # ["cast('2019-01-01' as date)", "date", "DATE"],
+            # ["cast('2019-01-01' as timestamp)", "date", "DATE"],
+        ]
+
+
+@pytest.mark.skip_profile('spark_session', 'apache_spark', 'databricks_sql_endpoint', 'databricks_cluster')
+class TestSparkConstraintsColumnsEqualDatabricksHTTP(BaseConstraintsColumnsEqual):
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {
+            "my_model_wrong_order.sql": my_model_wrong_order_sql,
+            "my_model_wrong_name.sql": my_model_wrong_name_sql,
+            "constraints_schema.yml": constraints_yml,
+        }
+
+    @pytest.fixture
+    def string_type(self):
+        return "STRING_TYPE"
+
+    @pytest.fixture
+    def int_type(self):
+        return "INT_TYPE"
+
+    @pytest.fixture
+    def schema_int_type(self):
+        return "INT"
+
+    @pytest.fixture
+    def data_types(self, int_type, schema_int_type, string_type):
+        # sql_column_value, schema_data_type, error_data_type
+        return [
+            # TODO: the int type is tricky to test in test__constraints_wrong_column_data_type without a schema_string_type to override.
+            # uncomment the line below once https://github.com/dbt-labs/dbt-core/issues/7121 is resolved
+            # ['1', schema_int_type, int_type],
+            ['"1"', "string", string_type],
+            ["true", "boolean", "BOOLEAN_TYPE"],
+            ['array("1","2","3")', "array<string>", "ARRAY_TYPE"],
+            ['array(1,2,3)', "array<int>", "ARRAY_TYPE"],
+            ["cast('2019-01-01' as date)", "date", "DATE_TYPE"],
+            ["cast('2019-01-01' as timestamp)", "timestamp", "TIMESTAMP_TYPE"],
+            ["cast(1.0 AS DECIMAL(4, 2))", "decimal", "DECIMAL_TYPE"],
+        ]
+
 
 @pytest.mark.skip_profile('spark_session', 'apache_spark')
 class TestSparkConstraintsRuntimeEnforcement(BaseConstraintsRuntimeEnforcement):
+    @pytest.fixture(scope="class")
+    def models(self):
+        return {
+            "my_model.sql": my_model_sql,
+            "constraints_schema.yml": constraints_yml,
+        }
+
     @pytest.fixture(scope="class")
     def project_config_update(self):
         return {
             "models": {
                 "+file_format": "delta",
             }
         }
-    
+
     @pytest.fixture(scope="class")
     def expected_sql(self, project):
         relation = relation_from_name(project.adapter, "my_model")