Ordinal bar chart bars overlap and ticks don't align in 2.0

[bhatup]

Hi,

There is issue is composite chart.
There is no proper gap between 2 bars (though specified with .gap(10)). And ticks are not in center of bars.

[gordonwoodhull]

Again, @bhatup, would you please link to a short self-contained example?

[bhatup]

Sorry Gordon,

Please look into this example.
http://jsfiddle.net/av5nj/

[gordonwoodhull]

Thanks, that is very helpful, and a very simple example which should work.

I can confirm this is a regression in 2.0.0, possibly due to the new work on ordinal bar charts.

I simplified your example to a simple bar chart, and it still fails:
http://jsfiddle.net/gordonwoodhull/fWhhz/

A mostly-equivalent version using 1.6.0 works:
http://jsfiddle.net/gordonwoodhull/B77Ut/16/

I'm changing the issue title accordingly.

[bhatup]

Hello @gordonwoodhull,

I have resolved this issue by doing modification in calculateBarWidth() function in dc.js

Just added the statement:
numberOfBars = (_chart.isOrdinal()) ? numberOfBars + 1 : numberOfBars;

This statement has been added in dc.1.6.js

[gordonwoodhull]

Okay, thanks. Looks like that line got lost in
03cf450 Use RangeBands for Ordinal Coordinate Grid Charts
and I verified your fix locally.

I'm wary of just pushing the fix, since the changes in that commit look intentional. Let's see if we can summon @jrideout...

[gordonwoodhull]

I determined that this is not the right fix. It helps but it just errs the other way. Something is deeply messed up about bar widths. Plan to fix for 2.0

[umdjm]

Issue raised again at http://stackoverflow.com/questions/24848550/bar-overlapping-in-dc-bar-chart

"Bar overlapping in DC bar chart"

[gordonwoodhull]

Thanks for linking. Yep this code is seriously screwed up. Maybe I'll hit this next.

Also: #593 changing number of bars.

[gordonwoodhull]

I think this is possibly the worst bug in dc right now. Just frightening results, yuk.

[mr23]

I agree its at the top. Just had to work around it Friday.

On July 20, 2014 4:10:52 PM CDT, Gordon Woodhull notifications@github.com wrote:

I think this is possibly the worst bug in dc right now. Just
frightening results, yuk.

---

Reply to this email directly or view it on GitHub:
#533 (comment)

Sent from my Android device with K-9 Mail. Please excuse my brevity.

[gordonwoodhull]

PRs always welcome.

My preference is to ditch the custom logic, or use it only when .gap is specified, and otherwise always do this the d3 way, with rangeBands. I think that will scale to grouped bars better, too.

[gordonwoodhull]

As a workaround, use .barPadding, which disables .gap and uses the d3 bar allocation algorithms instead. I'm still going to fix this, because unfortunately a gap of 2 is currently the default, and the d3 methods don't have a way to set a pixel gap, only a percentage.

[gordonwoodhull]

next time around, use rangeBounds for all bar charts unless _gap is set