Allow optionally passing in path to config files #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Greg,
Should I merge the PR and post a new release?
Eric
…On Wed, Feb 15, 2017 at 3:51 PM, Greg Von Kuster ***@***.***> wrote:
@ewafula <https://github.com/ewafula> I've done some baseline testing on
this PR, but have been hung up on enhancements to the
plant_tribes_scaffold_download tool that will accommodate the config files
archives. I'll be doing lots more testing on this PR tomorrow.
------------------------------
You can view, comment on, or merge this pull request online at:
#6
Commit Summary
- Allow optionally passing in path to config files
File Changes
- *M* pipelines/AssemblyPostProcesser
<https://github.com/dePamphilis/PlantTribes/pull/6/files#diff-0> (38)
- *M* pipelines/GeneFamilyClassifier
<https://github.com/dePamphilis/PlantTribes/pull/6/files#diff-1> (68)
- *M* pipelines/PhylogenomicsAnalysis
<https://github.com/dePamphilis/PlantTribes/pull/6/files#diff-2> (35)
Patch Links:
- https://github.com/dePamphilis/PlantTribes/pull/6.patch
- https://github.com/dePamphilis/PlantTribes/pull/6.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADLdeKOqdwh_nUYg7wwj9iBrXpQnjAviks5rc2U3gaJpZM4MCOv2>
.
|
|
Greg,
I have drafted a new release, v0.5 with your PR and the PASTA error
handling.
Eric
…On Wed, Feb 15, 2017 at 3:51 PM, Greg Von Kuster ***@***.***> wrote:
@ewafula <https://github.com/ewafula> I've done some baseline testing on
this PR, but have been hung up on enhancements to the
plant_tribes_scaffold_download tool that will accommodate the config files
archives. I'll be doing lots more testing on this PR tomorrow.
------------------------------
You can view, comment on, or merge this pull request online at:
#6
Commit Summary
- Allow optionally passing in path to config files
File Changes
- *M* pipelines/AssemblyPostProcesser
<https://github.com/dePamphilis/PlantTribes/pull/6/files#diff-0> (38)
- *M* pipelines/GeneFamilyClassifier
<https://github.com/dePamphilis/PlantTribes/pull/6/files#diff-1> (68)
- *M* pipelines/PhylogenomicsAnalysis
<https://github.com/dePamphilis/PlantTribes/pull/6/files#diff-2> (35)
Patch Links:
- https://github.com/dePamphilis/PlantTribes/pull/6.patch
- https://github.com/dePamphilis/PlantTribes/pull/6.diff
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#6>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ADLdeKOqdwh_nUYg7wwj9iBrXpQnjAviks5rc2U3gaJpZM4MCOv2>
.
|
|
@ewafula I still have more work on this today. I’ll be posting another PR today related to this. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ewafula I've done some baseline testing on this PR, but have been hung up on enhancements to the plant_tribes_scaffold_download tool that will accommodate the config files archives. I'll be doing lots more testing on this PR tomorrow.