Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to use protocol stream in node-minecraft-protocol #26

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update to use protocol stream in node-minecraft-protocol #26

wants to merge 3 commits into from

Conversation

deathcap
Copy link
Owner

@deathcap deathcap mentioned this pull request Jan 18, 2016
Merged
3 tasks
@deathcap
Copy link
Owner Author

deathcap commented Feb 7, 2016

There is now a stream option on the client, could and should use it possibly, but note WSMC still disables packet framing/splitting transforms (maybe can re-enable now that PrismarineJS/node-minecraft-protocol#316 Send framed packets in one push(), is merged, and consider removing framing/splitting later as an optimization, but keeping it now for code cleanliness)

@deathcap
Copy link
Owner Author

deathcap commented Feb 7, 2016

PrismarineJS/node-minecraft-protocol#320 has been merged, updated this PR to use the new stream option to createClient(), but needs more testing - from my initial tests, I'm not getting any chunks, requires more investigation. Switching from new Client to createClient() is a fairly large change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deathcap