feat: image widget insert from url should be optional (#5572)

decaporg · Jul 5, 2021 · 18724ff · 18724ff
1 parent 97353b6
commit 18724ff
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 10 deletions.
diff --git a/packages/netlify-cms-widget-file/src/withFileControl.js b/packages/netlify-cms-widget-file/src/withFileControl.js
@@ -291,7 +291,7 @@ export default function withFileControl({ forImage } = {}) {
     };
 
     renderSelection = subject => {
-      const { t } = this.props;
+      const { t, field } = this.props;
       return (
         <div>
           {forImage ? this.renderImages() : null}
@@ -300,9 +300,11 @@ export default function withFileControl({ forImage } = {}) {
             <FileWidgetButton onClick={this.handleChange}>
               {t(`editor.editorWidgets.${subject}.chooseDifferent`)}
             </FileWidgetButton>
-            <FileWidgetButton onClick={this.handleUrl(subject)}>
-              {t(`editor.editorWidgets.${subject}.replaceUrl`)}
-            </FileWidgetButton>
+            {field.get('choose_url', true) ? (
+              <FileWidgetButton onClick={this.handleUrl(subject)}>
+                {t(`editor.editorWidgets.${subject}.replaceUrl`)}
+              </FileWidgetButton>
+            ) : null}
             <FileWidgetButtonRemove onClick={this.handleRemove}>
               {t(`editor.editorWidgets.${subject}.remove`)}
             </FileWidgetButtonRemove>
@@ -312,15 +314,17 @@ export default function withFileControl({ forImage } = {}) {
     };
 
     renderNoSelection = subject => {
-      const { t } = this.props;
+      const { t, field } = this.props;
       return (
         <>
           <FileWidgetButton onClick={this.handleChange}>
             {t(`editor.editorWidgets.${subject}.choose`)}
           </FileWidgetButton>
-          <FileWidgetButton onClick={this.handleUrl(subject)}>
-            {t(`editor.editorWidgets.${subject}.chooseUrl`)}
-          </FileWidgetButton>
+          {field.get('choose_url', true) ? (
+            <FileWidgetButton onClick={this.handleUrl(subject)}>
+              {t(`editor.editorWidgets.${subject}.chooseUrl`)}
+            </FileWidgetButton>
+          ) : null}
         </>
       );
     };

diff --git a/website/content/docs/widgets/file.md b/website/content/docs/widgets/file.md
@@ -17,6 +17,7 @@ The file widget allows editors to upload a file or select an existing one from t
     * `config`: a configuration object that will be passed directly to the media library being
       used - available options are determined by the library
     * `media_folder` (Beta): file path where uploaded files will be saved specific to this control. Paths can be relative to a collection folder (e.g. `files` will add the file to a sub-folder in the collection folder) or absolute with reference to the base of the repo which needs to begin with `/` (e.g `/static/files` will save uploaded files to the `static` folder in a sub folder named `files`)
+    * `choose_url`: *(default: `true`)* when set to `false`, the "Insert from URL" button will be hidden
 * **Example:**
 
   ```yaml

diff --git a/website/content/docs/widgets/image.md b/website/content/docs/widgets/image.md
@@ -14,15 +14,17 @@ The image widget allows editors to upload an image or select an existing one fro
     current widget
   * `allow_multiple`: *(default: `true`)* when set to `false`, multiple selection will be disabled even if the media library extension supports it
   * `config`: a configuration object passed directly to the media library; check the documentation of your media library extension for available `config` options
-  * `media_folder` (Beta): file path where uploaded images will be saved specific to this control. Paths can be relative to a collection folder (e.g. `images` will add the image to a sub-folder in the collection folder) or absolute with reference to the base of the repo which needs to begin with `/` (e.g `/static/images` will save uploaded images to the `static` folder in a sub folder named `images`)  
+  * `media_folder` (Beta): file path where uploaded images will be saved specific to this control. Paths can be relative to a collection folder (e.g. `images` will add the image to a sub-folder in the collection folder) or absolute with reference to the base of the repo which needs to begin with `/` (e.g `/static/images` will save uploaded images to the `static` folder in a sub folder named `images`)
+  * `choose_url`: *(default: `true`)* when set to `false`, the "Insert from URL" button will be hidden
 * **Example:**
 
 ```yaml
   - label: "Featured Image"
     name: "thumbnail"
     widget: "image"
+    choose_url: true
     default: "/uploads/chocolate-dogecoin.jpg"
     media_library:
       config:
         multiple: true
-```
+```