Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor adjustment to tdw-did production #48

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Minor adjustment to tdw-did production #48

merged 1 commit into from
Apr 15, 2024

Conversation

andrewwhitehead
Copy link
Contributor

No description provided.

Signed-off-by: Andrew Whitehead <cywolf@gmail.com>
Copy link
Collaborator

@swcurran swcurran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well — really just cancel the PR. :-)

@@ -43,7 +43,7 @@ segment in the (optional) URL path. See examples below. The `domain-segment` and
would inevitably be wrong.

```abnf
tdw-did = "did:tdw:" *( domain-segment “.” ) scid 1*( “.” domain-segment ) ( “.” domain-segment ) *( ":" path-segment )
tdw-did = "did:tdw:" *( domain-segment “.” ) scid 2*( “.” domain-segment ) *( ":" path-segment )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually correct with the 1. Drummond did these and we went through them. Not the extra domain segment after the “1*” one. So it is say “0 or more sub-domains + SCID + one or more sub-domains and domain + the final TLD”

So the 2 would not be right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced 1*( “.” domain-segment ) ( “.” domain-segment ) with 2*( “.” domain-segment ) which is equivalent as far as I can tell

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No because that would you mean you have to have 3 segments after the SCID, and you only need two.

SCID.example.com is all that is required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where you're getting 3 from?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scid 1*( “.” domain-segment ) ( “.” domain-segment )

That’s SCID + 1 or more DS + DS — that’s 2 or more.

If we put the 2 where you want it, we get SCID + 2 or more DS + DS, which is 3 or more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not just replacing a 1 with a 2 though, it's replacing the extra domain segment

@swcurran
Copy link
Collaborator

OK - :-). You are right — I missed that. I knew when I started this, I would not “win" this discussion. And it is easier to understand with what you suggest.

@swcurran swcurran merged commit 6c5f81c into main Apr 15, 2024
1 check passed
@andrewwhitehead andrewwhitehead deleted the fix/abnf branch April 17, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants