Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor adjustment to tdw-did production #48

Merged
merged 1 commit into from
Apr 15, 2024
Merged

Minor adjustment to tdw-did production #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spec/specification.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ segment in the (optional) URL path. See examples below. The `domain-segment` and
would inevitably be wrong.

```abnf
tdw-did = "did:tdw:" *( domain-segment “.” ) scid 1*( “.” domain-segment ) ( “.” domain-segment ) *( ":" path-segment )
tdw-did = "did:tdw:" *( domain-segment “.” ) scid 2*( “.” domain-segment ) *( ":" path-segment )
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is actually correct with the 1. Drummond did these and we went through them. Not the extra domain segment after the “1*” one. So it is say “0 or more sub-domains + SCID + one or more sub-domains and domain + the final TLD”

So the 2 would not be right.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I replaced 1*( “.” domain-segment ) ( “.” domain-segment ) with 2*( “.” domain-segment ) which is equivalent as far as I can tell

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No because that would you mean you have to have 3 segments after the SCID, and you only need two.

SCID.example.com is all that is required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure where you're getting 3 from?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scid 1*( “.” domain-segment ) ( “.” domain-segment )

That’s SCID + 1 or more DS + DS — that’s 2 or more.

If we put the 2 where you want it, we get SCID + 2 or more DS + DS, which is 3 or more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not just replacing a 1 with a 2 though, it's replacing the extra domain segment

tdw-did = "did:tdw:" 2*( domain-segment “.” ) *( ":" path-segment ) (":" scid ) *( ":" path-segment )
domain-segment = ; A part of a domain name as defined in RFC3986, such as "example" and "com" in "example.com"
path-segment= ; A part of a URL path as defined in RFC3986, such as "path", "to", "folder" in "path/to/folder"
Expand Down