-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
eth: Add backend methods. #1154
Comments
|
Included Will do |
I'll work on the client |
I'll do |
Contract is in the pipeline so moving to server's |
#1089 will change/add some client methods |
Will do |
Also started on |
I'll do |
I'll do |
Will do |
Will work on server's |
Will do |
Actually looks like |
I'll do |
@JoeGruffins please remove the |
@buck54321 #1243 exists |
I'm really sorry about that, @JoeGruffins. I should have taken a wider look at this stuff earlier. |
it's fine. I really didn't want to mess with the server as much as possible, but I'm confident your way is better. I was just going to shoehorn it in there. |
Here's what I'm looking at for required communications.
1 Leave amount encoded for internal use, but only send address in the actual 2 I'm going to propose something different for contract address validation, but if we do want to validate the contract address, it'll need to be done earlier than this anyway, so let's not plan to send it here. 3 We may want to record the redemption transaction IDs too, but it seems less important for eth. There's also |
I'll look into the server |
Go for it, @JoeGruffins. I'll claim |
@buck54321 If you're working on Background for why call data + confirmations is not sufficient to determine redeemability: #1274 (comment) |
Or, um, I guess |
Regarding the CoinID to send during the |
I'll do |
I'll do |
I guess I'll take a whack at the Withdrawal TODOs since they are still there and probably not related to other's work. |
I'm working on |
I'll do |
I'll work on |
I guess I'll do |
I guess I'll do the server's ValidateSignature. |
This issue is meant to track adding functionality to eth swaps. Currently there is a bare bones implementation. Anyone who would like to work on adding a method, please comment here first so work is not duplicated.
As the dex was originally designed with UTXO based coins in mind, some methods may require far reaching changes.
server
- [ ] FundingCoin(ctx context.Context, coinID []byte, redeemScript []byte) (asset.FundingCoin, error)- [ ] VerifyUnspentCoin(ctx context.Context, coinID []byte)client
- [ ] Confirmations(ctx context.Context, id dex.Bytes) (confs uint32, spent bool, err error)- [ ] RefundAddress(contract dex.Bytes) (string, error)changelog
The text was updated successfully, but these errors were encountered: