client/eth: implement Exists #1332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chappjc
reviewed
Dec 7, 2021
| keyStoreDir := filepath.Join(getWalletDir(dataDir, net), "keystore") | ||
| ks := keystore.NewKeyStore(keyStoreDir, keystore.LightScryptN, keystore.LightScryptP) |
There was a problem hiding this comment.
There are three different magic values that must match elsewhere, including the new "keystore". Can we make these package-level?
buck54321
force-pushed
the
eth-driver-exists
branch
from
6a5d5e8
to
2d6d4cb
Compare
chappjc
approved these changes
Dec 7, 2021
|
Will allow more reviews since this isn't required for other urgent work. |
JoeGruffins
approved these changes
Dec 8, 2021
|
Have a test failure in #1335 that may or may not be related to these changes. |
Exists works by trying to load the keystore and checking for > 1 wallets. Remove unused "appdir" setting from custom config. Just use CreateWalletParams.DataDir.
chappjc
force-pushed
the
eth-driver-exists
branch
from
2d6d4cb
to
f38c96d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Existsworks by trying to load the keystore and checking for > 1wallets. Remove unused
"appdir"setting from custom config. We alreadyhave
CreateWalletParams.DataDir.