Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

eth/client: AuditContract #1319

Merged
merged 4 commits into from
Dec 9, 2021
Merged

eth/client: AuditContract #1319

merged 4 commits into from
Dec 9, 2021

Conversation

martonp
Copy link
Contributor

@martonp martonp commented Nov 30, 2021 •
edited
Loading

Part of #1154

@chappjc chappjc added the ETH label Nov 30, 2021
chappjc
chappjc reviewed Nov 30, 2021
View reviewed changes
client/asset/eth/eth.go Outdated Show resolved Hide resolved
client/asset/eth/eth.go Show resolved Hide resolved
@martonp martonp marked this pull request as ready for review December 1, 2021 13:15
JoeGruffins
JoeGruffins approved these changes Dec 3, 2021
View reviewed changes
Copy link
Member

@JoeGruffins JoeGruffins left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm embarrassingly not up to date with all the communication changes, but this looks good to me.

client/asset/eth/eth.go Show resolved Hide resolved
buck54321
buck54321 reviewed Dec 5, 2021
View reviewed changes
Copy link
Member

@buck54321 buck54321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was holding off on reviewing this until the ParseInitiateData changes come through, but if it's important to anyone to get it earlier, we can.

@chappjc
Copy link
Member

chappjc commented Dec 5, 2021

I was holding off on reviewing this until the ParseInitiateData changes come through, but if it's important to anyone to get it earlier, we can.

I dunno if order matters too much. Whoever does the ParseInitiateData etc changes can apply it to AuditContract too.

@martonp
Copy link
Contributor Author

martonp commented Dec 6, 2021

I was holding off on reviewing this until the ParseInitiateData changes come through, but if it's important to anyone to get it earlier, we can.

I dunno if order matters too much. Whoever does the ParseInitiateData etc changes can apply it to AuditContract too.

I'm working on them right now, but yeah this can be merged first.

buck54321
buck54321 approved these changes Dec 6, 2021
View reviewed changes
Copy link
Member

@buck54321 buck54321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good for now. Obviously a lot will be changing here with versioned ParseInitiateData and #1320.

chappjc
chappjc reviewed Dec 7, 2021
View reviewed changes
client/asset/eth/eth.go Outdated Show resolved Hide resolved
@martonp martonp mentioned this pull request Dec 9, 2021
Merged
@chappjc chappjc merged commit bd1d3b2 into decred:master Dec 9, 2021
@buck54321 buck54321 mentioned this pull request Dec 28, 2021
Closed
@martonp martonp deleted the auditContract branch December 20, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@buck54321 buck54321 buck54321 approved these changes

@chappjc chappjc chappjc approved these changes

@JoeGruffins JoeGruffins JoeGruffins approved these changes

Assignees
No one assigned
Labels
ETH
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martonp @chappjc @buck54321 @JoeGruffins