This repository has been archived by the owner on Nov 3, 2022. It is now read-only.
436 processing changes #482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
March 15, 2021 21:39
Merged
mfbieber
approved these changes
Mar 27, 2021
src/main/java/de/bonndan/nivio/input/ItemRelationProcessor.java
Outdated
Show resolved
Hide resolved
src/main/java/de/bonndan/nivio/input/ItemRelationProcessor.java
Outdated
Show resolved
Hide resolved
| */ | ||
| public static void compareStrings(String a, String b, String key, List<String> changes) { | ||
| if (!org.apache.commons.lang3.StringUtils.equals(a, b)) { | ||
| changes.add(key + " changed to: " + b); |
There was a problem hiding this comment.
Any thoughts on thread safety and reads and writes to the changes List in nivio? Does it matter and could we run into problems?
There was a problem hiding this comment.
Maybe. And modifying changes is a side effect. Since every compare method returns void, I'll rewrite them to return changes instead.
added 7 commits
March 28, 2021 07:33
# Conflicts: # src/main/java/de/bonndan/nivio/input/DiffProcessor.java # src/test/java/de/bonndan/nivio/model/GroupTest.java
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows tracking of landscape component (Group, Item, Relation) changes on field level in order to highlight changes in the UI.
requirement for #436