Skip to content
This repository has been archived by the owner on Nov 3, 2022. It is now read-only.

439 removed items #497

Merged
merged 5 commits into from
Mar 27, 2021
Merged

439 removed items #497

merged 5 commits into from
Mar 27, 2021

Conversation

bonndan
Copy link
Collaborator

@bonndan bonndan commented Mar 27, 2021

closes #439

@bonndan bonndan requested a review from mfbieber March 27, 2021 06:42
mfbieber
mfbieber suggested changes Mar 27, 2021
View reviewed changes
Copy link
Contributor

@mfbieber mfbieber left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, but I still have to manually reload the frontend to see the changes that were made.

Sometimes the frontend reloads after the next change has been made, but does not display the latest one. I think something is still off.

@mfbieber
Copy link
Contributor

#482 has the same change/reloading issue btw. The backend detects changes, but showing the results in the frontend lag behind by one change

mfbieber
mfbieber approved these changes Mar 27, 2021
View reviewed changes
Copy link
Contributor

@mfbieber mfbieber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, my mistake. Needed to rebuild the frontend with yarn install.

@bonndan bonndan merged commit 70726d5 into develop Mar 27, 2021
@bonndan bonndan deleted the 439_removed_items branch March 27, 2021 17:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mfbieber mfbieber mfbieber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Removed items still visible after update cycle
2 participants
@bonndan @mfbieber