Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to Go 1.15 #655

Merged
merged 2 commits into from
Aug 18, 2020
Merged

Adapt to Go 1.15 #655

merged 2 commits into from
Aug 18, 2020

Conversation

jeffallen
Copy link
Contributor

No description provided.

Jeff R. Allen added 2 commits August 17, 2020 15:24
Go 1.15 introduces stricter rules for what kinds of certificate will
validate, which causes our custom handshake protocol to fail.
Switch to sending/verifying the remote public key by way of the
URIs field of the certificate instead.

Fixes #653.
@jeffallen jeffallen requested a review from ineiti August 18, 2020 11:01
@jeffallen jeffallen self-assigned this Aug 18, 2020
Copy link
Member

@ineiti ineiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice test.

@jeffallen jeffallen merged commit a088414 into master Aug 18, 2020
@jeffallen jeffallen deleted the go15 branch August 18, 2020 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants