Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make better error message for TLS 1.5 fix #657

Closed
ineiti opened this issue Aug 21, 2020 · 0 comments · Fixed by #662
Closed

Make better error message for TLS 1.5 fix #657

ineiti opened this issue Aug 21, 2020 · 0 comments · Fixed by #662
Assignees
Labels

Comments

@ineiti
Copy link
Member

ineiti commented Aug 21, 2020

The fix for go 1.15 with regard to TLS, #655, made the test-network crash. Some more information can be found in #656, which is, however, not capable of reproducing the error in a way that we can try to fix it.

So as the minimal service to users of our code, I propose we do the following:

Improve the error message given by an incompatible onet-connection and be more clear what might have happened. E.g., something like:

TLS handshake failed - this might be due to mismatching go-version numbers, e.g., 1.14 and 1.15, between nodes. Another reason might be nodes running with onet (3.2.4) that cannot communicate with onet (3.2.5)

We should also consider removing the 3.2.5 tag and replacing it with a 3.3.0 tag, and write something in the CHANGELOG.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants