Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when a failed connection might be from a known bug #662

Merged
merged 2 commits into from
Sep 1, 2020
Merged

Conversation

jeffallen
Copy link
Contributor

Fixes #657

@jeffallen jeffallen self-assigned this Sep 1, 2020
network/tcp.go Outdated Show resolved Hide resolved
Co-authored-by: Linus Gasser <linus.gasser@epfl.ch>
@jeffallen
Copy link
Contributor Author

The build failed due to a data race that seems to be associated with graceful:

WARNING: DATA RACE
314Read at 0x00c0001189f8 by goroutine 106:
315  net/http.(*conn).setState()
316      /home/travis/.gimme/versions/go1.15.linux.amd64/src/net/http/server.go:1753 +0x110
317  net/http.(*conn).serve.func1()
318      /home/travis/.gimme/versions/go1.15.linux.amd64/src/net/http/server.go:1806 +0xfd
319  net/http.(*conn).serve()
320      /home/travis/.gimme/versions/go1.15.linux.amd64/src/net/http/server.go:1945 +0xaff
321
322Previous write at 0x00c0001189f8 by goroutine 97:
323  gopkg.in/tylerb/graceful%2ev1.(*Server).manageConnections()
324      /home/travis/gopath/pkg/mod/gopkg.in/tylerb/graceful.v1@v1.2.15/graceful.go:399 +0x644
325
326Goroutine 106 (running) created at:
327  net/http.(*Server).Serve()
328      /home/travis/.gimme/versions/go1.15.linux.amd64/src/net/http/server.go:2969 +0x5d3
329  gopkg.in/tylerb/graceful%2ev1.(*Server).Serve()
330      /home/travis/gopath/pkg/mod/gopkg.in/tylerb/graceful.v1@v1.2.15/graceful.go:309 +0x472
331  gopkg.in/tylerb/graceful%2ev1.(*Server).ListenAndServe()
332      /home/travis/gopath/pkg/mod/gopkg.in/tylerb/graceful.v1@v1.2.15/graceful.go:147 +0xf2
333  go.dedis.ch/onet/v3.(*WebSocket).start.func1()
334      /home/travis/gopath/src/go.dedis.ch/onet/v3/websocket.go:194 +0x15c
335
336Goroutine 97 (finished) created at:
337  gopkg.in/tylerb/graceful%2ev1.(*Server).Serve()
338      /home/travis/gopath/pkg/mod/gopkg.in/tylerb/graceful.v1@v1.2.15/graceful.go:297 +0x377
339  gopkg.in/tylerb/graceful%2ev1.(*Server).ListenAndServe()
340      /home/travis/gopath/pkg/mod/gopkg.in/tylerb/graceful.v1@v1.2.15/graceful.go:147 +0xf2
341  go.dedis.ch/onet/v3.(*WebSocket).start.func1()
342      /home/travis/gopath/src/go.dedis.ch/onet/v3/websocket.go:194 +0x15c
343==================
344    testing.go:1023: race detected during execution of test
345--- FAIL: TestLocalTCPGenConnectableRoster (0.48s)
346=== CONT  
347    testing.go:1023: race detected during execution of test
348

We already have #601 reminding us to get rid of graceful, so I'm going to merge this anyway.

@jeffallen jeffallen merged commit 3ac7df9 into master Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make better error message for TLS 1.5 fix
2 participants