chore: update dependencies

.github/workflows/node.js.yml

@@ -7,10 +7,12 @@ on:
       - develop
     paths:
       - "azure-devops-extension/run-automator-build-task/**"
+      - .github/workflows/node.js.yml
   pull_request:
     types: [opened, synchronize, reopened]
     paths:
       - "azure-devops-extension/run-automator-build-task/**"
+      - .github/workflows/node.js.yml
 
 jobs:
   node-test:
@@ -26,6 +28,12 @@ jobs:
           node-version: ${{ matrix.node-version }}
           cache: 'yarn'
       - run: npm install -g yarn
-      - run: yarn install --frozen-lockfile
-      - run: yarn build
-      - run: yarn test
+      - name: Install dependencies
+        run: yarn install --frozen-lockfile
+        working-directory: azure-devops-extension/run-automator-build-task
+      - name: Build
+        run: yarn build
+        working-directory: azure-devops-extension/run-automator-build-task
+      - name: Test
+        run: yarn test
+        working-directory: azure-devops-extension/run-automator-build-task

.gitignore

@@ -1,3 +1,4 @@
 .DS_Store
 node_modules
 dist
+.taskkey

azure-devops-extension/README.md

@@ -30,41 +30,6 @@ It has the following tasks:
 
 _Note: Unless `startOnly` is set to `true`, max polling time is set to 50 minutes. If the build takes longer than 50 minutes, it will automatically fail the pipeline._
 
-### How to test (QA)
-
-- Create accounts on: https://dev.azure.com/ (use @deepcrawl email address)
-- Ask for extension permissions
-- Once permission is given, install the extension from: https://marketplace.visualstudio.com/items?itemName=deepcrawl.automator-tools
-- Generate an API key on: https://legacy.deepcrawl.com/dc-api
-- Make sure you have the test suite created and the test suite id, if not create your test suite in Protect: https://protect.lumar.io/
-- Create new private repository with default README: https://github.com/new
-- Go to your Azure Organisation page: http://dev.azure.com/
-- Create new project
-- Pipelines -> Create new pipeline
-- Authorise Github and set the repo to the one created previously
-- Install it to your repo
-- Select Starter Pipeline , once in Configure tab
-- On next step, complete the `yaml`file with:
-
-```yaml
-trigger:
-- master
-pool:
-  vmImage: 'ubuntu-latest'
-steps:
-- task: run-automator-build-task@1
-  inputs:
-    userKeyId: 'USER_KEY_ID' (string - generate new api key on Lumar core app)
-    userKeySecret: 'USER_KEY_SECRET' (string - generate new api key on Lumar core app)
-    testSuiteId: 'TEST_SUITE_ID' (string - use your created test suite id)
-    ciBuildId: 'CI_BUILD_ID' (optional - string)
-    startOnly: false (optional - boolean - use it if you want to skip polling)
-```
-
-- Save and run
-- Go to the job and check it
-- Once tested, make sure to remove the Lumar api key generated
-
 ### Inputs
 
 #### Required variables
@@ -81,67 +46,3 @@ testSuiteId: <string>
 startOnly: <boolean>
 ciBuildId: <string>
 ```
-
-### Requirements
-
-- Install yarn globally
-
-```
-npm install -g yarn
-```
-
-- Install npm packages
-
-```
-yarn
-```
-
-### Build
-
-```
-yarn build
-```
-
-### Running locally
-
-To run locally, set the following environment variables:
-
-```
-INPUT_USERKEYID: <string> (required)
-INPUT_USERKEYSECRET: <string> (required)
-INPUT_TESTSUITEID: <string> (required)
-INPUT_STARTONLY: <boolean> (optional)
-INPUT_CIBUILDID: <string> (optional)
-```
-
-and run:
-
-```
-yarn start
-```
-
-### Test
-
-```
-yarn test
-```
-
-### Lint
-
-```
-yarn lint
-```
-
-## Release
-
-In order to release, the following steps should be followed:
-
-- In each of your modified task, increment the version of the task in `task.json`
-- Increment the version of the extension accordingly, in `vss-extension.json`
-- Package the extension:
-
-```
-yarn release
-```
-
-- Manually release the extension through Azure Devops extensions

azure-devops-extension/package.json

@@ -10,6 +10,6 @@
   "author": "Andrei Bitca, Daniel Mon Chit & Lukas Kalcok",
   "license": "ISC",
   "devDependencies": {
-    "tfx-cli": "^0.9.2"
+    "tfx-cli": "^0.14.0"
   }
 }

azure-devops-extension/run-automator-build-task/docs/build.md

@@ -0,0 +1,19 @@
+### Requirements
+
+- Install yarn globally
+
+```
+npm install -g yarn
+```
+
+- Install npm packages
+
+```
+yarn
+```
+
+### Build
+
+```
+yarn build
+```

azure-devops-extension/run-automator-build-task/docs/release.md

@@ -0,0 +1,15 @@
+## Release
+
+Requires: [Build](build.md)
+
+In order to release, the following steps should be followed:
+
+- In each of your modified task, increment the version of the task in `task.json`
+- Increment the version of the extension accordingly, in `vss-extension.json`
+- Package the extension:
+
+```
+yarn release
+```
+
+- Manually release the extension through Azure Devops extensions

azure-devops-extension/run-automator-build-task/docs/run-local.md

@@ -0,0 +1,17 @@
+### Running locally
+
+To run locally, set the following environment variables:
+
+```
+INPUT_USERKEYID: <string> (required)
+INPUT_USERKEYSECRET: <string> (required)
+INPUT_TESTSUITEID: <string> (required)
+INPUT_STARTONLY: <boolean> (optional)
+INPUT_CIBUILDID: <string> (optional)
+```
+
+and run:
+
+```
+yarn start
+```

azure-devops-extension/run-automator-build-task/docs/test-qa.md

@@ -0,0 +1,34 @@
+### How to test (QA)
+
+- Create accounts on: https://dev.azure.com/ (use @deepcrawl email address)
+- Ask for extension permissions
+- Once permission is given, install the extension from: https://marketplace.visualstudio.com/items?itemName=deepcrawl.automator-tools
+- Generate an API key on: https://legacy.deepcrawl.com/dc-api
+- Make sure you have the test suite created and the test suite id, if not create your test suite in Protect: https://protect.lumar.io/
+- Create new private repository with default README: https://github.com/new
+- Go to your Azure Organisation page: http://dev.azure.com/
+- Create new project
+- Pipelines -> Create new pipeline
+- Authorise Github and set the repo to the one created previously
+- Install it to your repo
+- Select Starter Pipeline , once in Configure tab
+- On next step, complete the `yaml`file with:
+
+```yaml
+trigger:
+- master
+pool:
+  vmImage: 'ubuntu-latest'
+steps:
+- task: run-automator-build-task@1
+  inputs:
+    userKeyId: 'USER_KEY_ID' (string - generate new api key on Lumar core app)
+    userKeySecret: 'USER_KEY_SECRET' (string - generate new api key on Lumar core app)
+    testSuiteId: 'TEST_SUITE_ID' (string - use your created test suite id)
+    ciBuildId: 'CI_BUILD_ID' (optional - string)
+    startOnly: false (optional - boolean - use it if you want to skip polling)
+```
+
+- Save and run
+- Go to the job and check it
+- Once tested, make sure to remove the Lumar api key generated

azure-devops-extension/run-automator-build-task/jest.config.js

@@ -7,6 +7,7 @@ module.exports = {
   automock: false,
   collectCoverage: true,
   collectCoverageFrom: ["<rootDir>/src/**/*.ts", "!<rootDir>/src/**/*.integration.ts", "!<rootDir>/src/**/*.test.ts"],
+  coveragePathIgnorePatterns: ["<rootDir>/src/index.ts", "<rootDir>/src/automator-sdk-client.ts"],
   coverageDirectory: "coverage",
   coverageReporters: ["html", "json", "text-summary"],
   coverageThreshold: {

azure-devops-extension/run-automator-build-task/package.json

@@ -16,46 +16,37 @@
   },
   "author": "Andrei Bitca, Daniel Mon Chit & Lukas Kalcok",
   "license": "ISC",
+  "resolutions": {
+    "cross-fetch": "3.1.5",
+    "minimatch": "7.4.2",
+    "ws": "8.12.1"
+  },
   "devDependencies": {
     "@types/jest": "^26.0.22",
-    "@types/nock": "^11.1.0",
-    "@types/node-fetch": "^2.5.7",
-    "@types/pino": "^6.3.2",
+    "@types/node-fetch": "^2.6.2",
     "@types/q": "^1.5.4",
     "@types/sinon": "^9.0.8",
-    "@typescript-eslint/eslint-plugin": "^4.1.1",
-    "@zerollup/ts-transform-paths": "^1.7.18",
-    "eslint": "^7.9.0",
-    "eslint-config-deepcrawl": "^5.6.0",
-    "eslint-plugin-array-func": "^3.1.7",
-    "eslint-plugin-clean-code": "^0.1.12",
-    "eslint-plugin-filenames": "^1.3.2",
+    "eslint": "^8.35.0",
+    "eslint-config-deepcrawl": "^8.1.0",
     "eslint-plugin-graphql": "^4.0.0",
-    "eslint-plugin-import": "^2.22.0",
-    "eslint-plugin-jest": "^24.0.2",
-    "eslint-plugin-json-format": "^2.0.1",
-    "eslint-plugin-no-loops": "^0.3.0",
-    "eslint-plugin-node": "^11.1.0",
-    "eslint-plugin-promise": "^4.2.1",
-    "eslint-plugin-sonarjs": "^0.5.0",
     "jest": "^26.6.3",
     "jest-extended": "^0.11.5",
     "jest-fetch-mock": "^3.0.3",
-    "nock": "^13.0.4",
+    "nock": "^13.3.0",
     "prettier": "^2.1.2",
     "sinon": "^9.2.0",
     "ts-jest": "^26.4.1",
-    "ttypescript": "^1.5.12",
+    "ttypescript": "^1.5.15",
     "typescript": "^4.0.3",
+    "typescript-transform-paths": "3.4.6",
     "y18n": "4.0.1"
   },
   "dependencies": {
     "@apollo/client": "^3.2.2",
     "axios": "^0.21.1",
-    "azure-pipelines-task-lib": "^2.11.2",
-    "graphql": "^15.3.0",
-    "node-fetch": "^2.6.1",
-    "pino": "^6.7.0",
-    "pino-pretty": "^4.3.0"
+    "azure-pipelines-task-lib": "^4.3.0",
+    "graphql": "^16.6.0",
+    "node-fetch": "^2.6.9",
+    "winston": "3.8.2"
   }
 }

azure-devops-extension/run-automator-build-task/src/_common/helpers/sleep.helper.test.ts

@@ -6,6 +6,6 @@ describe("#sleep", () => {
     await sleep(1000);
     const endTimeStamp = Date.now();
     const secondsPassed = Math.floor((endTimeStamp - startTimeStamp) / 1000);
-    expect(secondsPassed).toEqual(1);
+    expect(secondsPassed).toBe(1);
   });
 });

azure-devops-extension/run-automator-build-task/src/_common/services/logger.service.ts

@@ -1,6 +1,17 @@
-import * as pino from "pino";
+import {createLogger, format, transports} from "winston";
 
-export const loggerService = pino({
-  level: "info",
-  prettyPrint: true,
+const {colorize, combine, timestamp, printf} = format;
+const upperLevel = format(info => {
+  info.level = info.level.toUpperCase();
+  return info;
+});
+
+export const loggerService = createLogger({
+  format: combine(
+    upperLevel(),
+    colorize({all: true}),
+    timestamp({format: "HH:mm:ss.sss"}),
+    printf(({level, message, timestamp}) => `[${timestamp}] ${level} (${process.pid}) : ${message}`),
+  ),
+  transports: [new transports.Console()]
 });

azure-devops-extension/run-automator-build-task/src/index.ts

@@ -1,4 +1,4 @@
-import azurePipelinesTask = require("azure-pipelines-task-lib");
+import azurePipelinesTask = require("azure-pipelines-task-lib/task");
 
 import { inputParameters } from "@common/constants";
 import { loggerService } from "@common/services/logger.service";

azure-devops-extension/run-automator-build-task/src/sdk/automator-sdk-client.test.ts

@@ -40,7 +40,7 @@ describe("AutomatorSDKClient", () => {
           ciBuildId,
         }),
       ).rejects.toEqual(new Error(testSuiteId));
-      expect(deleteAuthTokenSpy.calledOnceWith(`${userKeyId}|${userKeySecret}`)).toEqual(true);
+      expect(deleteAuthTokenSpy.calledOnceWith(`${userKeyId}|${userKeySecret}`)).toBe(true);
     });
 
     it("should throw error and delete token if tools api client #poll throws error", async () => {
@@ -70,8 +70,8 @@ describe("AutomatorSDKClient", () => {
         ciBuildId,
         isStartOnly: true,
       });
-      expect(pollSpy.notCalled).toEqual(true);
-      expect(deleteAuthTokenSpy.calledOnceWith(`${userKeyId}|${userKeySecret}`)).toEqual(true);
+      expect(pollSpy.notCalled).toBe(true);
+      expect(deleteAuthTokenSpy.calledOnceWith(`${userKeyId}|${userKeySecret}`)).toBe(true);
     });
 
     it("should delete token in the end", async () => {
@@ -85,7 +85,7 @@ describe("AutomatorSDKClient", () => {
         testSuiteId,
         ciBuildId,
       });
-      expect(deleteAuthTokenSpy.calledOnceWith(`${userKeyId}|${userKeySecret}`)).toEqual(true);
+      expect(deleteAuthTokenSpy.calledOnceWith(`${userKeyId}|${userKeySecret}`)).toBe(true);
     });
   });
 });

azure-devops-extension/run-automator-build-task/src/sdk/graph-api/__snapshots__/graph-api-client.test.ts.snap

@@ -7,8 +7,7 @@ Object {
     token
     __typename
   }
-}
-",
+}",
   "variables": Object {},
 }
 `;
@@ -23,8 +22,7 @@ Object {
     token
     __typename
   }
-}
-",
+}",
   "variables": Object {
     "userKeyId": "user-key-id",
     "userKeySecret": "user-key-secret",