Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FigureExtractor to have client/core features. Closes #1760 #1771

Merged
merged 9 commits into from
Jul 20, 2020

Conversation

umesh-timalsina
Copy link
Contributor

Closes #1760.

Copy link
Contributor

@brollb brollb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good start! See comments below.

src/common/viz/FigureExtractor.js Outdated Show resolved Hide resolved
src/common/viz/FigureExtractor.js Outdated Show resolved Hide resolved
src/common/viz/FigureExtractor.js Outdated Show resolved Hide resolved
src/common/viz/FigureExtractor.js Outdated Show resolved Hide resolved
src/visualizers/panels/PlotlyGraph/PlotlyGraphControl.js Outdated Show resolved Hide resolved
1. All the functions using client/core changed to operate on NodeInfoJSON
2. Address PR review suggestions
3. Grab GraphNode from controllers: `PlotlyGraphControl`, `ExecutionIndexControl`
1. Fix nodejs btoa function unavailability
2. Change FigureReference.json to a single line
3. Refactor extract method to both client/core FigureExtractor
test/unit/common/viz/FigureExtractor.spec.js Show resolved Hide resolved
desc = {
id: id,
execId: execId,
type: this.getMetaType(nodeInfo) === EXTRACTORS.PLOT3D ? 'plot3D' : 'plot2D',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is "plot2D" lowercase here (rather than conforming to the earlier "Plot2D"? Since this isn't a change added in this commit, it doesn't need to be changed here but I just find it a bit odd...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FigureExtractor desc.type is lowercase Graph nodes and below. It might be nice to change it to use upper case. However, it might not be a priority considering #1745 / #1747 will not use this code.

@brollb brollb merged commit 3b93adb into master Jul 20, 2020
@brollb brollb deleted the 1760-figextr-rftr branch July 20, 2020 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants