Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor FigureExtractor to have client/core features. Closes #1760 #1771

Merged
merged 9 commits into from
Jul 20, 2020
Merged

Refactor FigureExtractor to have client/core features. Closes #1760 #1771

merged 9 commits into from
Jul 20, 2020

Commits on Jul 15, 2020

  1. Refactor FigureExtractor to have client/core features. Closes #1760

    @umesh-timalsina
    umesh-timalsina committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    3e432f0 View commit details
    Browse the repository at this point in the history

  2. WIP- Fix unused arguments in AbstractFigureExtractor

    @umesh-timalsina
    umesh-timalsina committed Jul 15, 2020
    Configuration menu
    Copy the full SHA
    6b58227 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. Refactor AbstractFigureExtractor to operate on nodeInfo 

    1. All the functions using client/core changed to operate on NodeInfoJSON
2. Address PR review suggestions
3. Grab GraphNode from controllers: `PlotlyGraphControl`, `ExecutionIndexControl`
    @umesh-timalsina
    umesh-timalsina committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    0691fa1 View commit details
    Browse the repository at this point in the history

  2. Test generated desc instead of JSON nodes in FigureExtractor.spec 

    1. Fix nodejs btoa function unavailability
2. Change FigureReference.json to a single line
3. Refactor extract method to both client/core FigureExtractor
    @umesh-timalsina
    umesh-timalsina committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    8eca9ed View commit details
    Browse the repository at this point in the history

  3. WIP- refactor toJSON method in FigureExtractor

    @umesh-timalsina
    umesh-timalsina committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    6356ffc View commit details
    Browse the repository at this point in the history

  4. WIP- fix error message for toJSON method in AbstractFigureExtractor

    @umesh-timalsina
    umesh-timalsina committed Jul 16, 2020
    Configuration menu
    Copy the full SHA
    609e1d5 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2020

  1. WIP- add cache in parameters list for AbstractFigureExtractor

    @umesh-timalsina
    umesh-timalsina committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    ec0f712 View commit details
    Browse the repository at this point in the history

  2. Add toJSON parent/child relation test

    @umesh-timalsina
    umesh-timalsina committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    c00efca View commit details
    Browse the repository at this point in the history

  3. WIP-Add cache in children.toJSON in CoreFigureExtractor 

    Also, add test to check equality of objects
    @umesh-timalsina
    umesh-timalsina committed Jul 17, 2020
    Configuration menu
    Copy the full SHA
    669b708 View commit details
    Browse the repository at this point in the history