Integer overflow potential in SortedRanges.subRangeByPos

[jcferretti]

The code:

        final long inputRangeSpan = endPos - startPos;
        [...]
        int ansLen = count - i + (brokenInitialRange ? 2 : 1);
        ansLen = Math.min(ansLen, (int) (inputRangeSpan + 1));

has the potential to leave ansLen negative is inputRangeSpan + 1 does not fit on an int.

Charles found the issue after looking for a potential root cause for this exception seen in the wild:

16:09:16.285 ERROR 571924851 where([AutoTuningIncrementalReleaseFilter-290518179[2]]) Merged Listener: Uncaught exception for entry= Entry{clientHost=‘null’, queryName=‘null’, id=1, description=‘where([AutoTuningIncrementalReleaseFilter-290518179[1]]): where([AutoTuningIncrementalReleaseFilter-290518179[2]])’, callerLine=‘Groovy Script’, intervalUsageNanos=10928571, intervalInvocationCount=6, intervalCpuNanos=10928446, intervalUserCpuNanos=10000000, intervalAdded=0, intervalRemoved=0, intervalModified=0, intervalShifted=0, intervalInitialReads=0, intervalInitialReadUsageNanos=0, intervalRepeatReads=0, intervalRepeatReadUsageNanos=0, intervalAllocatedBytes=13656, intervalPoolAllocatedBytes=0, startCpuNanos=0, startUserCpuNanos=0, startTimeNanos=0, startInitialReads=0, startInitialReadNanos=0, startRepeatReads=0, startRepeatReadNanos=0, startAllocatedBytes=0, startPoolAllocatedBytes=0, totalUsedMemory=9731059712, totalFreeMemory=2026648000}: java.lang.NegativeArraySizeException: null
        at com.illumon.iris.db.v2.utils.sortedranges.SortedRangesLong.makeArray(SortedRangesLong.java:47)
        at com.illumon.iris.db.v2.utils.sortedranges.SortedRangesLong.makeArray(SortedRangesLong.java:5)
        at com.illumon.iris.db.v2.utils.sortedranges.SortedRangesTyped.<init>(SortedRangesTyped.java:13)
        at com.illumon.iris.db.v2.utils.sortedranges.SortedRangesLong.<init>(SortedRangesLong.java:113)
        at com.illumon.iris.db.v2.utils.sortedranges.SortedRangesLong.makeMyTypeAndOffset(SortedRangesLong.java:65)
        at com.illumon.iris.db.v2.utils.sortedranges.SortedRangesLong.makeMyTypeAndOffset(SortedRangesLong.java:5)
        at com.illumon.iris.db.v2.utils.sortedranges.SortedRanges.subRangesByPos(SortedRanges.java:1076)
        at com.illumon.iris.db.v2.utils.sortedranges.SortedRanges.ixSubindexByPosOnNew(SortedRanges.java:4448)
        at com.illumon.iris.db.v2.utils.TreeIndex.subindexByPos(TreeIndex.java:232)
        at com.illumon.iris.db.v2.select.BaseIncrementalReleaseFilter.filter(BaseIncrementalReleaseFilter.java:75)
        at com.illumon.iris.db.v2.QueryTable.whereInternal(QueryTable.java:1053)
        at com.illumon.iris.db.v2.QueryTable$FilteredTable.doRefilter(QueryTable.java:891)
        at com.illumon.iris.db.v2.QueryTable$FilteredTable.access$700(QueryTable.java:798)
        at com.illumon.iris.db.v2.QueryTable$StaticWhereListener.process(QueryTable.java:3156)
        at com.illumon.iris.db.v2.MergedListener$1.run(MergedListener.java:129)
        at com.illumon.iris.db.tables.live.LiveTableMonitor.runNotification(LiveTableMonitor.java:1306)
        at com.illumon.iris.db.tables.live.LiveTableMonitor.access$1100(LiveTableMonitor.java:69)
        at com.illumon.iris.db.tables.live.LiveTableMonitor$ConcurrentNotificationProcessor.processSatisfiedNotifications(LiveTableMonitor.java:1348)
        at com.illumon.iris.db.tables.live.LiveTableMonitor$LiveTableMonitorThreadFactory.lambda$newThread$0(LiveTableMonitor.java:1804)
        at java.lang.Thread.run(Thread.java:748)