-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable casting PyObject's to primitives; provide type param info for py lists #1490
Merged
nbauernfeind
merged 14 commits into
deephaven:main
from
nbauernfeind:pyobject_primitive_cast
Nov 3, 2021
Merged
Enable casting PyObject's to primitives; provide type param info for py lists #1490
nbauernfeind
merged 14 commits into
deephaven:main
from
nbauernfeind:pyobject_primitive_cast
Nov 3, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbauernfeind
added
bug
Something isn't working
NoDocumentationNeeded
repl
python-server-side
labels
Oct 27, 2021
nbauernfeind
commented
Oct 27, 2021
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageParser.java
Outdated
Show resolved
Hide resolved
niloc132
reviewed
Oct 27, 2021
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionGenerator.java
Outdated
Show resolved
Hide resolved
niloc132
reviewed
Oct 27, 2021
nbauernfeind
force-pushed
the
pyobject_primitive_cast
branch
from
October 27, 2021 23:23
7f691da
to
6a74800
Compare
rcaudy
reviewed
Oct 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change overall. Needs more testing, and maybe some cleanup in Param
.
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionGenerator.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionGenerator.java
Outdated
Show resolved
Hide resolved
nbauernfeind
force-pushed
the
pyobject_primitive_cast
branch
2 times, most recently
from
November 1, 2021 18:05
4f6c80b
to
27f288f
Compare
rcaudy
reviewed
Nov 1, 2021
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionUtil.java
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageParser.java
Outdated
Show resolved
Hide resolved
nbauernfeind
force-pushed
the
pyobject_primitive_cast
branch
2 times, most recently
from
November 1, 2021 23:06
81c8134
to
03836c3
Compare
nbauernfeind
force-pushed
the
pyobject_primitive_cast
branch
from
November 1, 2021 23:11
03836c3
to
5ddec66
Compare
nbauernfeind
force-pushed
the
pyobject_primitive_cast
branch
from
November 1, 2021 23:12
5ddec66
to
6de58a1
Compare
rcaudy
reviewed
Nov 2, 2021
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionUtil.java
Outdated
Show resolved
Hide resolved
nbauernfeind
force-pushed
the
pyobject_primitive_cast
branch
from
November 2, 2021 15:07
156bccc
to
6de58a1
Compare
chipkent
requested changes
Nov 2, 2021
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionGenerator.java
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionUtil.java
Show resolved
Hide resolved
rcaudy
previously approved these changes
Nov 2, 2021
chipkent
reviewed
Nov 2, 2021
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionGenerator.java
Show resolved
Hide resolved
chipkent
requested changes
Nov 2, 2021
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionGenerator.java
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionGenerator.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionGenerator.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionGenerator.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionGenerator.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionUtil.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionUtil.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionUtil.java
Outdated
Show resolved
Hide resolved
DB/src/main/java/io/deephaven/db/tables/lang/DBLanguageFunctionUtil.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Chip Kent <5250374+chipkent@users.noreply.github.com>
chipkent
previously approved these changes
Nov 2, 2021
nbauernfeind
force-pushed
the
pyobject_primitive_cast
branch
from
November 2, 2021 23:19
73c7c9d
to
49a57df
Compare
rcaudy
approved these changes
Nov 2, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also did this for String/boolean/Boolean:
Note that after some discussion we preferred to NPE when casting to boolean and the value is a None. We also decided that a String cast should throw an exception if not already a String (instead of converting via
PyObject::str
).Fixes #1009