Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[groovy] strange error message when using anonymous groovy objects #1518

Closed
nbauernfeind opened this issue Nov 1, 2021 · 0 comments · Fixed by #1522
Closed

[groovy] strange error message when using anonymous groovy objects #1518

nbauernfeind opened this issue Nov 1, 2021 · 0 comments · Fixed by #1522
Assignees
Labels
Milestone

Comments

@nbauernfeind
Copy link
Member

Description

A clear and concise description of what the bug is.

Steps to reproduce

x = new Object() {
    long get(long ii) { return ii; }
}
y = emptyTable(1).update("X = x[ii]")

Expected results

An error message of the following style:

Having trouble with the following expression:
Full expression           : x[ii]
Expression having trouble : io.deephaven.db.tables.lang.DBLanguageParser$VisitArgs@1e199514
Exception message         : Cannot find method get(long) in interface groovy.lang.GroovyObject

Actual results

/io/deephaven/temp/c415813373987228486v61_0/Formula.java:80: error: <identifier> expected
    private final io.deephaven.dynamic.Script_6.1 x;
                                               ^
/io/deephaven/temp/c415813373987228486v61_0/Formula.java:80: error: <identifier> expected
    private final io.deephaven.dynamic.Script_6.1 x;
                                                   ^
/io/deephaven/temp/c415813373987228486v61_0/Formula.java:89: error: ')' expected
        x = (io.deephaven.dynamic.Script_6.1) __params[0].getValue();

Additional details and attachments

I suspect it's a JDK upgrade side effect.

I have a fix but interferes with the PyObject #1490 - so will put up the the PR immediately when that merges.

@nbauernfeind nbauernfeind added this to the Nov 2021 milestone Nov 1, 2021
@nbauernfeind nbauernfeind self-assigned this Nov 1, 2021
@pete-petey pete-petey modified the milestones: Nov 2021, Backlog Dec 29, 2021
@pete-petey pete-petey modified the milestones: Backlog, Jan 2022 Apr 15, 2022
mofojed pushed a commit that referenced this issue Sep 27, 2023
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.49.1

### Bug Fixes

* Copy did not work from embedded iframes ([#1528](deephaven/web-client-ui#1528)) ([3549a33](deephaven/web-client-ui@3549a33)), closes [#1527](deephaven/web-client-ui#1527)
* Dehydration of class components ([#1535](deephaven/web-client-ui#1535)) ([3e834de](deephaven/web-client-ui@3e834de)), closes [#1534](deephaven/web-client-ui#1534)
* inconsistent drag for webkit ([#1518](deephaven/web-client-ui#1518)) ([cd5408c](deephaven/web-client-ui@cd5408c)), closes [#1360](deephaven/web-client-ui#1360)
* Render tables partitioned by non-string columns ([#1533](deephaven/web-client-ui#1533)) ([585b2ff](deephaven/web-client-ui@585b2ff)), closes [#1441](deephaven/web-client-ui#1441)
* Right clicking with a custom context menu open should open another context menu ([#1526](deephaven/web-client-ui#1526)) ([bd08e1f](deephaven/web-client-ui@bd08e1f)), closes [#1525](deephaven/web-client-ui#1525)

# [0.49.0](deephaven/web-client-ui@v0.48.0...v0.49.0) (2023-09-15)


### Bug Fixes

* Plugin peer dependencies do not get versions from lerna ([#1517](deephaven/web-client-ui#1517)) ([322f6ff](deephaven/web-client-ui@322f6ff))
* Table overflow button has lower priority than grid tokens ([#1510](deephaven/web-client-ui#1510)) ([32e6d20](deephaven/web-client-ui@32e6d20)), closes [#1480](deephaven/web-client-ui#1480)


### Code Refactoring

* Improve table saver to always use the correct service worker ([#1515](deephaven/web-client-ui#1515)) ([2488e52](deephaven/web-client-ui@2488e52)), closes [#766](deephaven/web-client-ui#766)


### Features

* Update go to row panel's row number with cursorRow ([#1508](deephaven/web-client-ui#1508)) ([23ab5cc](deephaven/web-client-ui@23ab5cc)), closes [#1406](deephaven/web-client-ui#1406)


### BREAKING CHANGES

* `TableSaver` now expects the service worker to send it
a complete URL for download instead of just a file name. DHE will need
to adjust its `serviceWorker.js` to incorporate the same changes from
this PR.


Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants