Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete leftJoin (and clean up Attributes, since I forget to delete that class) #1619

Merged
merged 9 commits into from
Dec 1, 2021
Merged

Delete leftJoin (and clean up Attributes, since I forget to delete that class) #1619

merged 9 commits into from
Dec 1, 2021

Conversation

rcaudy
Copy link
Member

@rcaudy rcaudy commented Dec 1, 2021

Closes #1615

@rcaudy rcaudy added this to the Nov 2021 milestone Dec 1, 2021
@rcaudy rcaudy self-assigned this Dec 1, 2021
@kosak
Copy link
Contributor

kosak commented Dec 1, 2021

For protoc, you can cherry-pick commit b1d6f64 from the branch "ryan5" in my repo, namely https://github.com/kosak/deephaven-core/tree/ryan5

kosak
kosak previously approved these changes Dec 1, 2021
View reviewed changes
cpwright
cpwright previously approved these changes Dec 1, 2021
View reviewed changes
@rcaudy rcaudy dismissed stale reviews from cpwright and kosak via a44edd6 December 1, 2021 15:03
jmao-denver
jmao-denver previously approved these changes Dec 1, 2021
View reviewed changes
niloc132
niloc132 previously approved these changes Dec 1, 2021
View reviewed changes
niloc132
niloc132 previously approved these changes Dec 1, 2021
View reviewed changes
nbauernfeind
nbauernfeind previously approved these changes Dec 1, 2021
View reviewed changes
@rcaudy rcaudy force-pushed the rwc-deleteleftjoin-1 branch from 641e7bd to c0be649 Compare December 1, 2021 20:43
niloc132
niloc132 previously approved these changes Dec 1, 2021
View reviewed changes
nbauernfeind
nbauernfeind previously approved these changes Dec 1, 2021
View reviewed changes
@rcaudy rcaudy dismissed stale reviews from nbauernfeind and niloc132 via 2731f09 December 1, 2021 22:32
@rcaudy rcaudy merged commit db50d7f into deephaven:main Dec 1, 2021
@rcaudy rcaudy deleted the rwc-deleteleftjoin-1 branch December 1, 2021 23:04
@github-actions github-actions bot locked and limited conversation to collaborators Dec 1, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nbauernfeind nbauernfeind nbauernfeind approved these changes

@cpwright cpwright cpwright left review comments

@jmao-denver jmao-denver jmao-denver left review comments

@kosak kosak kosak left review comments

@niloc132 niloc132 niloc132 left review comments

Assignees

@rcaudy rcaudy

Labels
clean up DocumentationNeeded query engine
Projects
None yet
Milestone
Nov 2021
Development

Successfully merging this pull request may close these issues.

Delete leftJoin from Table interface
6 participants
@rcaudy @kosak @niloc132 @nbauernfeind @jmao-denver @cpwright