Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete leftJoin from Table interface #1615

Closed
rcaudy opened this issue Nov 30, 2021 · 0 comments · Fixed by #1619
Closed

Delete leftJoin from Table interface #1615

rcaudy opened this issue Nov 30, 2021 · 0 comments · Fixed by #1619
Assignees
@rcaudy
Labels
feature request New feature or request query engine
Milestone
Nov 2021

Comments

@rcaudy
Copy link
Member

rcaudy commented Nov 30, 2021 •
edited
Loading

The semantics are just bad. It is currently equivalent to a:
left=left.naturalJoin(right.groupBy(“Columns”), “Columns”).
This is an OK thing to want to do, but has extremely expensive tick expansion semantics. We would like to delete leftJoin for now and bring that name back in the future for a SQL-style left join operation.
@rcaudy rcaudy added feature request New feature or request query engine labels Nov 30, 2021
@rcaudy rcaudy added this to the Nov 2021 milestone Nov 30, 2021
@rcaudy rcaudy self-assigned this Nov 30, 2021
@rcaudy rcaudy mentioned this issue Dec 1, 2021
Merged
mofojed pushed a commit that referenced this issue Nov 3, 2023
@github-actions @deephaven-internal
Update web version 0.53.0 (#4770)
77b25b0 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.53.0

# [0.53.0](deephaven/web-client-ui@v0.52.0...v0.53.0) (2023-11-03)


### Bug Fixes

* DH-15864: Scroll position StuckToBottom shouldn't trigger sharing dot ([#1617](deephaven/web-client-ui#1617)) ([3d4499b](deephaven/web-client-ui@3d4499b))
* Panel focus throwing an exception ([#1609](deephaven/web-client-ui#1609)) ([9e8b7ae](deephaven/web-client-ui@9e8b7ae))
* Plugins were re-registering on every re-render ([#1613](deephaven/web-client-ui#1613)) ([5977389](deephaven/web-client-ui@5977389))


### Features

* Add support for multi-partition parquet:kv tables ([#1580](deephaven/web-client-ui#1580)) ([d92c91e](deephaven/web-client-ui@d92c91e)), closes [#1143](deephaven/web-client-ui#1143) [#1438](deephaven/web-client-ui#1438)
* Babel Plugin - Mock css imports ([#1607](deephaven/web-client-ui#1607)) ([787c542](deephaven/web-client-ui@787c542)), closes [#1606](deephaven/web-client-ui#1606)
* Convert DashboardPlugins to WidgetPlugins ([#1598](deephaven/web-client-ui#1598)) ([a260842](deephaven/web-client-ui@a260842)), closes [#1573](deephaven/web-client-ui#1573)


### Reverts

* "fix: stuck to bottom on filter clear" ([#1616](deephaven/web-client-ui#1616)) ([806a6b6](deephaven/web-client-ui@806a6b6)), closes [deephaven/web-client-ui#1579](deephaven/web-client-ui#1579) [#1615](deephaven/web-client-ui#1615)

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rcaudy rcaudy

Labels
feature request New feature or request query engine
Projects
None yet
Milestone
Nov 2021
Development

Successfully merging a pull request may close this issue.

Delete leftJoin (and clean up Attributes, since I forget to delete that class) rcaudy/deephaven-core
1 participant
@rcaudy