Skip to content

Commit

Permalink
fix: adjust theme notice and info colors (#1779)
Browse files Browse the repository at this point in the history
Dark theme:
- notice changed from cyan to indigo
- positive contrast changed to dark

Light theme:
- fix hover/down state of postive, info, notice to go darker not lighter
- shift notice color bg variables to be less gross, more yellow
  • Loading branch information
dsmmcken authored Feb 8, 2024
1 parent e90b627 commit 8930522
Show file tree
Hide file tree
Showing 50 changed files with 16 additions and 16 deletions.
10 changes: 5 additions & 5 deletions packages/components/src/theme/theme-dark/theme-dark-semantic.css
Original file line number Diff line number Diff line change
Expand Up @@ -179,14 +179,14 @@
--dh-color-positive-hover-bg: var(--dh-color-green-800);
--dh-color-positive-down-bg: var(--dh-color-green-700);
--dh-color-positive-key-focus-bg: var(--dh-color-green-800);
--dh-color-positive-contrast: var(--dh-color-contrast-light);
--dh-color-positive-contrast: var(--dh-color-contrast-dark);

/* Informative */
--dh-color-info: var(--dh-color-cyan-1000);
--dh-color-info: var(--dh-color-indigo-900);
--dh-color-info-bg: var(--dh-color-info);
--dh-color-info-hover-bg: var(--dh-color-cyan-900);
--dh-color-info-down-bg: var(--dh-color-cyan-800);
--dh-color-info-key-focus-bg: var(--dh-color-cyan-900);
--dh-color-info-hover-bg: var(--dh-color-indigo-800);
--dh-color-info-down-bg: var(--dh-color-indigo-700);
--dh-color-info-key-focus-bg: var(--dh-color-indigo-800);
--dh-color-info-contrast: var(--dh-color-contrast-dark);

/* Notice */
Expand Down
22 changes: 11 additions & 11 deletions packages/components/src/theme/theme-light/theme-light-semantic.css
Original file line number Diff line number Diff line change
Expand Up @@ -176,26 +176,26 @@
/* Positive */
--dh-color-positive: var(--dh-color-green-900);
--dh-color-positive-bg: var(--dh-color-positive);
--dh-color-positive-hover-bg: var(--dh-color-green-800);
--dh-color-positive-down-bg: var(--dh-color-green-700);
--dh-color-positive-key-focus-bg: var(--dh-color-green-800);
--dh-color-positive-hover-bg: var(--dh-color-green-1000);
--dh-color-positive-down-bg: var(--dh-color-green-1100);
--dh-color-positive-key-focus-bg: var(--dh-color-green-1000);
--dh-color-positive-contrast: var(--dh-color-contrast-dark);

/* Informative */
--dh-color-info: var(--dh-color-cyan-1000);
--dh-color-info-bg: var(--dh-color-info);
--dh-color-info-hover-bg: var(--dh-color-cyan-900);
--dh-color-info-down-bg: var(--dh-color-cyan-800);
--dh-color-info-key-focus-bg: var(--dh-color-cyan-900);
--dh-color-info-hover-bg: var(--dh-color-cyan-1100);
--dh-color-info-down-bg: var(--dh-color-cyan-1200);
--dh-color-info-key-focus-bg: var(--dh-color-cyan-1100);
--dh-color-info-contrast: var(--dh-color-contrast-dark);

/* Notice */
--dh-color-notice: var(--dh-color-yellow-1000);
--dh-color-notice: var(--dh-color-yellow-500);
--dh-color-notice-bg: var(--dh-color-notice);
--dh-color-notice-hover-bg: var(--dh-color-yellow-900);
--dh-color-notice-down-bg: var(--dh-color-yellow-800);
--dh-color-notice-key-focus-bg: var(--dh-color-yellow-1000);
--dh-color-notice-contrast: var(--dh-color-contrast-dark);
--dh-color-notice-hover-bg: var(--dh-color-yellow-600);
--dh-color-notice-down-bg: var(--dh-color-yellow-700);
--dh-color-notice-key-focus-bg: var(--dh-color-yellow-600);
--dh-color-notice-contrast: var(--dh-color-contrast-light);

/* Editing */
--dh-color-modified: var(--dh-color-green-700);
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified tests/styleguide.spec.ts-snapshots/semantic-colors-webkit-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/tooltips-chromium-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/tooltips-firefox-linux.png
Binary file modified tests/styleguide.spec.ts-snapshots/tooltips-webkit-linux.png

0 comments on commit 8930522

Please sign in to comment.