Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: adjust theme notice and info colors #1779

Merged
merged 2 commits into from
Feb 8, 2024
Merged

Conversation

dsmmcken
Copy link
Contributor

@dsmmcken dsmmcken commented Feb 7, 2024

Dark theme:

  • notice changed from cyan to indigo
  • positive contrast changed to dark

Light theme:

  • fix hover/down state of postive, info, notice to go darker not lighter
  • shift notice color bg variables to be less gross, more yellow

Dark theme:
- notice changed from cyan to indigo
- positive contrast changed to dark

Light theme:
- fix hover/down state of postive, info, notice to go darker not lighter
- shift notice color bg variables to be less gross, more yellow
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (51e60c5) 46.05% compared to head (5873f2f) 46.05%.

❗ Current head 5873f2f differs from pull request most recent head a6d9fdb. Consider uploading reports for the commit a6d9fdb to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1779   +/-   ##
=======================================
  Coverage   46.05%   46.05%           
=======================================
  Files         628      628           
  Lines       37781    37781           
  Branches     9516     9516           
=======================================
  Hits        17401    17401           
  Misses      20325    20325           
  Partials       55       55           
Flag Coverage Δ
unit 46.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mofojed mofojed merged commit 8930522 into main Feb 8, 2024
4 checks passed
@mofojed mofojed deleted the dmckenzie_info_notice_tweak branch February 8, 2024 15:03
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2024
@dsmmcken dsmmcken self-assigned this Feb 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants