fix: Catch errors when emitting events to prevent breaking entire lay…

…out (#1353)

- Added a try/catch around all events that are emitted from Golden
Layout
- Added @deephaven/log to golden layout so we can log the error
- Tested using the steps in
https://github.com/deephaven/deephaven-js-plugins/issues/26
- Fixes #1352

packages/golden-layout/src/utils/EventEmitter.ts

@@ -65,7 +65,11 @@ class EventEmitter {
     if (subs) {
       for (let i = 0; i < subs.length; i++) {
         const ctx = subs[i].ctx || {};
-        subs[i].fn.apply(ctx, args);
+        try {
+          subs[i].fn.apply(ctx, args);
+        } catch (e) {
+          console.error('Error while emitting event:', e);
+        }
       }
     }
 
@@ -75,7 +79,11 @@ class EventEmitter {
 
     for (let i = 0; i < allEventSubs.length; i++) {
       const ctx = allEventSubs[i].ctx || {};
-      allEventSubs[i].fn.apply(ctx, args);
+      try {
+        allEventSubs[i].fn.apply(ctx, args);
+      } catch (e) {
+        console.error('Error while emitting event to allEventSubs:', e);
+      }
     }
   }
 

packages/golden-layout/tsconfig.json

@@ -4,13 +4,6 @@
     "rootDir": "src/",
     "outDir": "dist/"
   },
-  "include": [
-    "src/**/*.ts",
-    "src/**/*.tsx",
-    "src/**/*.js",
-    "src/**/*.jsx"
-  ],
-  "exclude": [
-    "node_modules"
-  ]
-}
+  "include": ["src/**/*.ts", "src/**/*.tsx", "src/**/*.js", "src/**/*.jsx"],
+  "exclude": ["node_modules"]
+}