Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Golden Layout can break if a panel throws while dragging #1352

Closed
mofojed opened this issue Jun 7, 2023 · 0 comments · Fixed by #1353
Closed

Golden Layout can break if a panel throws while dragging #1352

mofojed opened this issue Jun 7, 2023 · 0 comments · Fixed by #1353
Assignees
@mofojed
Labels
bug Something isn't working

Comments

@mofojed
Copy link
Member

mofojed commented Jun 7, 2023

Description

Discovered while investigating deephaven/deephaven-plugins#40, the entire layout breaks when a panel throws while dragging. Add some safeguards to prevent one erroneous panel from breaking the entire layout.

Steps to reproduce

  1. Follow the steps in Plotly - multiple series plots with color axis cause error when trying to move panel deephaven-plugins#40

Expected results

  1. Panel should drop correctly, layout shouldn't be broken (though that particular panel may be displaying incorrectly)

Actual results

  1. Layout breaks, panel can't drop

Additional details and attachments

image
@mofojed mofojed added bug Something isn't working triage Issue requires triage labels Jun 7, 2023
@mofojed mofojed self-assigned this Jun 7, 2023
@mofojed mofojed removed the triage Issue requires triage label Jun 7, 2023
mofojed added a commit to mofojed/web-client-ui that referenced this issue Jun 7, 2023
@mofojed
fix: Catch errors when emitting events to prevent breaking entire layout
aaada44 
- Added a try/catch around all events that are emitted from Golden Layout
- Added @deephaven/log to golden layout so we can log the error
- Tested using the steps in https://github.com/deephaven/deephaven-js-plugins/issues/26
- Fixes deephaven#1352
@mofojed mofojed mentioned this issue Jun 7, 2023
Merged
mofojed added a commit to mofojed/web-client-ui that referenced this issue Jun 8, 2023
@mofojed
fix: Catch errors when emitting events to prevent breaking entire layout
9acb901 
- Added a try/catch around all events that are emitted from Golden Layout
- Added @deephaven/log to golden layout so we can log the error
- Tested using the steps in https://github.com/deephaven/deephaven-js-plugins/issues/26
- Fixes deephaven#1352
mofojed added a commit that referenced this issue Jun 8, 2023
@mofojed
fix: Catch errors when emitting events to prevent breaking entire lay…
aac5bd2 
…out (#1353)

- Added a try/catch around all events that are emitted from Golden
Layout
- Added @deephaven/log to golden layout so we can log the error
- Tested using the steps in
https://github.com/deephaven/deephaven-js-plugins/issues/26
- Fixes #1352
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mofojed mofojed

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Catch errors when emitting events to prevent breaking entire layout mofojed/web-client-ui
1 participant
@mofojed