fix: DH-16461: Preload --dh-color-text-highlight (#1780) (#1781)

DH-16461: Preload --dh-color-text-highlight **Testing** This doesn't actually impact anything in DHC. If you want to test in DHE, see test plan on DH-16461 and run `npm run start-community` in DHE.
deephaven · Feb 8, 2024 · f7989b6 · f7989b6
1 parent 8930522
commit f7989b6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 6 deletions.
diff --git a/packages/components/src/theme/ThemeModel.ts b/packages/components/src/theme/ThemeModel.ts
@@ -3,6 +3,11 @@ export type BaseThemeKey = `default-${BaseThemeType}`;
 export type CssVariableStyleContent = `:root{${string}`;
 export type ThemeCssVariableName = `--dh-${string}`;
 
+// DHC should only need to preload variables that are required by the empty page
+// with loading spinner that shows while plugins are loading. The rest of the
+// preload variables defined here are required by DHE due to theme plugins
+// loading after login. We should consider moving most of these to the DHE
+// codebase. To be addressed by #1679
 export type ThemePreloadColorVariable =
   | '--dh-color-accent-contrast'
   | '--dh-color-accent-bg'
@@ -20,9 +25,7 @@ export type ThemePreloadColorVariable =
   | '--dh-color-input-border'
   | '--dh-color-input-placeholder'
   | '--dh-color-input-focus-border'
-  // Preloading login specific variables should only be needed in DHE. Including
-  // them for now until we have a way for DHE to configure them. To be addressed
-  // by #1679
+  | '--dh-color-text-highlight'
   | '--dh-color-login-form-bg'
   | '--dh-color-login-status-message'
   | '--dh-color-login-logo-bg'
@@ -48,6 +51,7 @@ export const DEFAULT_DARK_THEME_PALETTE = {
     500: '#2f5bc0',
     400: '#254ba4',
     600: '#3b6bda', // accent color
+    700: '#4c7dee',
   },
   red: {
     600: '#c73f61',
@@ -66,6 +70,11 @@ export const DEFAULT_DARK_THEME_PALETTE = {
 } as const;
 
 // Css properties that are used in preload data with default values.
+// DHC should only need to preload variables that are required by the empty page
+// with loading spinner that shows while plugins are loading. The rest of the
+// preload variables defined here are required by DHE due to theme plugins
+// loading after login. We should consider moving most of these to the DHE
+// codebase. To be addressed by #1679
 export const DEFAULT_PRELOAD_DATA_VARIABLES: Record<
   ThemePreloadColorVariable,
   string
@@ -86,9 +95,7 @@ export const DEFAULT_PRELOAD_DATA_VARIABLES: Record<
   '--dh-color-input-border': DEFAULT_DARK_THEME_PALETTE.gray[600],
   '--dh-color-input-placeholder': DEFAULT_DARK_THEME_PALETTE.gray[600],
   '--dh-color-input-focus-border': `${DEFAULT_DARK_THEME_PALETTE.blue[600]}d9`, // 85% opacity
-  // Preloading login specific variables should only be needed in DHE. Including
-  // them for now until we have a way for DHE to configure them. To be addressed
-  // by #1679
+  '--dh-color-text-highlight': `${DEFAULT_DARK_THEME_PALETTE.blue[700]}4d`, // 30% opacity
   '--dh-color-login-form-bg': DEFAULT_DARK_THEME_PALETTE.gray[400],
   '--dh-color-login-status-message': DEFAULT_DARK_THEME_PALETTE.gray[600],
   '--dh-color-login-logo-bg': DEFAULT_DARK_THEME_PALETTE.gray[900],

diff --git a/packages/components/src/theme/__snapshots__/ThemeUtils.test.ts.snap b/packages/components/src/theme/__snapshots__/ThemeUtils.test.ts.snap
@@ -26,6 +26,7 @@ exports[`DEFAULT_PRELOAD_DATA_VARIABLES should match snapshot 1`] = `
   "--dh-color-random-area-plot-animation-fg-fill": "#3b6bda14",
   "--dh-color-random-area-plot-animation-fg-stroke": "#3b6bda33",
   "--dh-color-random-area-plot-animation-grid": "#373438",
+  "--dh-color-text-highlight": "#4c7dee4d",
 }
 `;