-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Go to row panel should update the row number as you navigate the selection #1406
Closed
vbabich opened this issue
Jul 11, 2023
· 2 comments
· Fixed by #1508 or deephaven/deephaven-core#4559
Closed
Go to row panel should update the row number as you navigate the selection #1406
vbabich opened this issue
Jul 11, 2023
· 2 comments
· Fixed by #1508 or deephaven/deephaven-core#4559
Labels
Milestone
Comments
vbabich
added
good first issue
Good for newcomers
and removed
triage
Issue requires triage
labels
Jul 12, 2023
Use |
Steps to Reproduce in DHC:
Expected Results: Actual Results: |
georgecwan
added a commit
that referenced
this issue
Sep 14, 2023
The row number in the go to row panel now updates when users click on a row in the table. The value displayed when multiple selections or ranges of rows are selected depends on the value of cursorRow. Fixes a bug where selecting a row then using the context menu to open the go to row panel would fill in the panel with the incorrect row number. Resolves #1406.
mofojed
pushed a commit
to deephaven/deephaven-core
that referenced
this issue
Sep 27, 2023
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.49.1 ### Bug Fixes * Copy did not work from embedded iframes ([#1528](deephaven/web-client-ui#1528)) ([3549a33](deephaven/web-client-ui@3549a33)), closes [#1527](deephaven/web-client-ui#1527) * Dehydration of class components ([#1535](deephaven/web-client-ui#1535)) ([3e834de](deephaven/web-client-ui@3e834de)), closes [#1534](deephaven/web-client-ui#1534) * inconsistent drag for webkit ([#1518](deephaven/web-client-ui#1518)) ([cd5408c](deephaven/web-client-ui@cd5408c)), closes [#1360](deephaven/web-client-ui#1360) * Render tables partitioned by non-string columns ([#1533](deephaven/web-client-ui#1533)) ([585b2ff](deephaven/web-client-ui@585b2ff)), closes [#1441](deephaven/web-client-ui#1441) * Right clicking with a custom context menu open should open another context menu ([#1526](deephaven/web-client-ui#1526)) ([bd08e1f](deephaven/web-client-ui@bd08e1f)), closes [#1525](deephaven/web-client-ui#1525) # [0.49.0](deephaven/web-client-ui@v0.48.0...v0.49.0) (2023-09-15) ### Bug Fixes * Plugin peer dependencies do not get versions from lerna ([#1517](deephaven/web-client-ui#1517)) ([322f6ff](deephaven/web-client-ui@322f6ff)) * Table overflow button has lower priority than grid tokens ([#1510](deephaven/web-client-ui#1510)) ([32e6d20](deephaven/web-client-ui@32e6d20)), closes [#1480](deephaven/web-client-ui#1480) ### Code Refactoring * Improve table saver to always use the correct service worker ([#1515](deephaven/web-client-ui#1515)) ([2488e52](deephaven/web-client-ui@2488e52)), closes [#766](deephaven/web-client-ui#766) ### Features * Update go to row panel's row number with cursorRow ([#1508](deephaven/web-client-ui#1508)) ([23ab5cc](deephaven/web-client-ui@23ab5cc)), closes [#1406](deephaven/web-client-ui#1406) ### BREAKING CHANGES * `TableSaver` now expects the service worker to send it a complete URL for download instead of just a file name. DHE will need to adjust its `serviceWorker.js` to incorporate the same changes from this PR. Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As you navigate the selection, the row number in the
Go to row
panel should change.The text was updated successfully, but these errors were encountered: