Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't show "Append Command" when onPartitionAppend prop is not provided #1414

Closed
mofojed opened this issue Jul 19, 2023 · 0 comments · Fixed by #1495
Closed

Don't show "Append Command" when onPartitionAppend prop is not provided #1414

mofojed opened this issue Jul 19, 2023 · 0 comments · Fixed by #1495
Assignees
Labels
bug Something isn't working good first issue Good for newcomers
Milestone

Comments

@mofojed
Copy link
Member

mofojed commented Jul 19, 2023

Description

When the onPartitionAppend prop is not provided to IrisGrid, do not show the Append Command in the Partition selector, as it won't do anything.

Steps to reproduce

  1. Open http://localhost:10000 and create a partition aware table:
from deephaven import new_table
from deephaven.column import int_col, double_col, string_col
grades1 = new_table([
    string_col("Name", ["Ashley", "Jeff", "Rita", "Zach"]),
    int_col("Test1", [92, 78, 87, 74]),
    int_col("Test2", [94, 88, 81, 70]),
    int_col("Average", [93, 83, 84, 72]),
    double_col("GPA", [3.9, 2.9, 3.0, 1.8])
])

grades2 = new_table([
    string_col("Name", ["Jose", "Martha", "Mary", "Richard"]),
    int_col("Test1", [67, 92, 87, 54]),
    int_col("Test2", [97, 99, 92, 63]),
    int_col("Average", [82, 96, 93, 59]),
    double_col("GPA", [4.0, 3.2, 3.6, 2.7])
])

from deephaven.parquet import write, read

write(grades1, "grades/school=elementary/part1.parquet")
write(grades2, "grades/school=middle/part2.parquet")

grades = read("grades")

This uses the format of Nested Parquet Tables to create a partition aware table.
2. Open the table in the iframe UI: http://localhost:10000/iframe/table?name=grades

Expected Results
2. "Append Command" button should not be there, as there is no console session to append the command to

Actual Results
2. "Append Command" button is there, and clicking it does nothing

@mofojed mofojed added bug Something isn't working triage Issue requires triage labels Jul 19, 2023
@vbabich vbabich added good first issue Good for newcomers and removed triage Issue requires triage labels Jul 19, 2023
@vbabich vbabich added this to the July 2023 milestone Jul 19, 2023
@mofojed mofojed modified the milestones: July 2023, August 2023 Aug 28, 2023
georgecwan added a commit that referenced this issue Sep 11, 2023
…in iframe UI (#1495)

* Currently, viewing a partition aware table in the iframe UI will show
the "Append Command" button even though there is no console session to
append the command to.
* Changed the partition selector to only render the "Append Command"
button when no `onPartitionAppend` prop is provided to IrisGrid. The
"Append Command" button should now be available in the IDE but not the
iframe UI.

* Resolves #1414
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
3 participants