Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide "Append Command" button when viewing partition aware table in iframe UI #1495

Merged
merged 10 commits into from
Sep 11, 2023

Conversation

georgecwan
Copy link
Contributor

  • Currently, viewing a partition aware table in the iframe UI will show the "Append Command" button even though there is no console session to append the command to.

  • Changed the partition selector to only render the "Append Command" button when no onPartitionAppend prop is provided to IrisGrid. The "Append Command" button should now be available in the IDE but not the iframe UI.

  • Resolves Don't show "Append Command" when onPartitionAppend prop is not provided #1414

@georgecwan georgecwan requested a review from mofojed September 8, 2023 14:05
packages/iris-grid/src/IrisGrid.tsx Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGridPartitionSelector.tsx Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 25.00% and project coverage change: +0.01% 🎉

Comparison is base (d35aa49) 45.76% compared to head (6f6cf3f) 45.77%.
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1495      +/-   ##
==========================================
+ Coverage   45.76%   45.77%   +0.01%     
==========================================
  Files         517      518       +1     
  Lines       35162    35180      +18     
  Branches     8802     8817      +15     
==========================================
+ Hits        16092    16104      +12     
- Misses      19019    19025       +6     
  Partials       51       51              
Flag Coverage Δ
unit 45.77% <25.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
packages/iris-grid/src/IrisGrid.tsx 26.96% <0.00%> (-0.04%) ⬇️
...ckages/iris-grid/src/IrisGridPartitionSelector.tsx 35.44% <50.00%> (+0.82%) ⬆️

... and 8 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgecwan georgecwan requested a review from mofojed September 8, 2023 15:45
@georgecwan georgecwan self-assigned this Sep 8, 2023
packages/iris-grid/src/IrisGrid.tsx Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGridPartitionSelector.tsx Outdated Show resolved Hide resolved
packages/iris-grid/src/IrisGridPartitionSelector.tsx Outdated Show resolved Hide resolved
@georgecwan georgecwan requested a review from mofojed September 8, 2023 19:13
@georgecwan georgecwan merged commit d15d6b1 into deephaven:main Sep 11, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't show "Append Command" when onPartitionAppend prop is not provided
2 participants