-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Theming - Charts #1608
feat: Theming - Charts #1608
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1608 +/- ##
=======================================
Coverage 46.71% 46.71%
=======================================
Files 583 586 +3
Lines 36308 36340 +32
Branches 9094 9095 +1
=======================================
+ Hits 16961 16977 +16
- Misses 19295 19311 +16
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
289bc10
to
144d2fe
Compare
ee3eb43
to
d7b4adc
Compare
ed0c47e
to
fd9a477
Compare
packages/components/src/theme/theme-dark/theme-dark-semantic-chart.css
Outdated
Show resolved
Hide resolved
packages/chart/src/MockChartModel.ts
Outdated
static _theme: ChartTheme; | ||
|
||
static get theme(): ChartTheme { | ||
/* eslint-disable no-underscore-dangle */ | ||
if (MockChartModel._theme == null) { | ||
MockChartModel._theme = initChartTheme(); | ||
} | ||
|
||
return MockChartModel._theme; | ||
/* eslint-enable no-underscore-dangle */ | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the theme be passed in to the constructor? As it is I don't see how this would update to if the user changes the theme in the Style Guide.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to only be used in static methods, so there's not really a constructor involved. I can probably just expose a setter that can be used by the Styleguide to change it, but I'll defer that until I implement the theme picker unless you have any objections.
fd9a477
to
9a9bf88
Compare
- Colorway to single var - Renamed chart theme init deephaven#1572
d1ece51
to
ff57e85
Compare
Added ChartThemeProvider, added support for resolving css variables in chart theme, and updated chart theme to use css variables.
resolves #1572
BREAKING CHANGE: