Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theming - Charts and Plots #1572

Closed
Tracked by #1537
bmingles opened this issue Oct 12, 2023 · 0 comments · Fixed by #1608 or deephaven/deephaven-core#4812
Closed
Tracked by #1537

Theming - Charts and Plots #1572

bmingles opened this issue Oct 12, 2023 · 0 comments · Fixed by #1608 or deephaven/deephaven-core#4812
Assignees
@bmingles
Labels
enhancement New feature or request web-client-ui

Comments

@bmingles
Copy link
Contributor

Update charting and plotting to use theme variables.

Epic: #1537
@bmingles bmingles added enhancement New feature or request web-client-ui triage Issue requires triage labels Oct 12, 2023
@bmingles bmingles mentioned this issue Oct 12, 2023
Closed
13 tasks
@vbabich vbabich removed the triage Issue requires triage label Oct 17, 2023
@vbabich vbabich added this to the October 2023 milestone Oct 17, 2023
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 31, 2023
@bmingles
ChartThemeProvider
2089a6d 
deephaven#1572
@bmingles bmingles mentioned this issue Oct 31, 2023
Merged
bmingles added a commit to bmingles/web-client-ui that referenced this issue Oct 31, 2023
@bmingles
Added required chartTheme to tests
9b97a3f 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 1, 2023
@bmingles
Chart theme HOC
f91c2c5 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 1, 2023
@bmingles
ChartThemeProvider
1ab9e6a 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 1, 2023
@bmingles
Added required chartTheme to tests
da97621 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 1, 2023
@bmingles
Chart theme HOC
fc8ecf7 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 1, 2023
@bmingles
Added types and comments
89de520 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 1, 2023
@bmingles
Removed withChartTheme HOC
289bc10 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 1, 2023
@bmingles
Removed withChartTheme HOC
144d2fe 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 1, 2023
@bmingles
Split custom createPlotlyComponent into own module
17ce46f 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 1, 2023
@bmingles
Added chart theme variables
3497711 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 1, 2023
@bmingles
Fixed tests
7d14823 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 2, 2023
@bmingles
Updated e2e snapshots
ee3eb43 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 2, 2023
@bmingles
ChartThemeProvider
99d59aa 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 2, 2023
@bmingles
Added required chartTheme to tests
c727178 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 2, 2023
@bmingles
Chart theme HOC
cf9a8d2 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 2, 2023
@bmingles
Added types and comments
1938eea 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 2, 2023
@bmingles
Removed withChartTheme HOC
a310d9c 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 2, 2023
@bmingles
Split custom createPlotlyComponent into own module
b7ad1e5 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 2, 2023
@bmingles
Added chart theme variables
e5febc8 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 2, 2023
@bmingles
Fixed tests
754bea9 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 2, 2023
@bmingles
Updated e2e snapshots
d7b4adc 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 3, 2023
@bmingles
Removed withChartTheme HOC
e9fa66d 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 3, 2023
@bmingles
Split custom createPlotlyComponent into own module
4e8c915 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 3, 2023
@bmingles
Added chart theme variables
271af31 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 3, 2023
@bmingles
Fixed tests
e4ca2fb 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 3, 2023
@bmingles
Updated e2e snapshots
807da20 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 3, 2023
@bmingles
Fixed color to be closer to original
d51b8e7 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 3, 2023
@bmingles
Fixed alpha on chart colors
c8250fd 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 3, 2023
@bmingles
Changed scattergl to scatter to fix styleguide
9a9bf88 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
Addressed code review comments
7d6c341 
- Colorway to single var
- Renamed chart theme init

deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
Parsing colorway vars
d1ece51 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
ChartThemeProvider
ead9438 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
Added required chartTheme to tests
c11362a 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
Chart theme HOC
3b128e0 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
Added types and comments
94276ff 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
Removed withChartTheme HOC
1e2f9ab 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
Split custom createPlotlyComponent into own module
6432cf6 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
Added chart theme variables
c32e39a 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
Fixed tests
1ebffd2 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
Updated e2e snapshots
6f71f65 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
Fixed color to be closer to original
a854bbe 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
Fixed alpha on chart colors
2fc528d 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
Changed scattergl to scatter to fix styleguide
4a6d4b0 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
Addressed code review comments
a142786 
- Colorway to single var
- Renamed chart theme init

deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
Parsing colorway vars
ff57e85 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
Made chart theme required
90c39df 
deephaven#1572
bmingles added a commit to bmingles/web-client-ui that referenced this issue Nov 6, 2023
@bmingles
package lock
fa1435e 
deephaven#1572
bmingles added a commit that referenced this issue Nov 7, 2023
@bmingles
feat: Theming - Charts (#1608)
d5b3b48 
Added ChartThemeProvider, added support for resolving css variables in
chart theme, and updated chart theme to use css variables.

resolves #1572

BREAKING CHANGE: 
- ChartThemeProvider is now required to provide ChartTheme
- ChartModelFactory and ChartUtils now require chartTheme args
@mofojed mofojed mentioned this issue Nov 10, 2023
Merged
mofojed pushed a commit to deephaven/deephaven-core that referenced this issue Nov 10, 2023
@github-actions @deephaven-internal
Update web version 0.54.0 (#4812)
c9652a1 
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.54.0

# [0.54.0](deephaven/web-client-ui@v0.53.0...v0.54.0) (2023-11-10)


### Bug Fixes

* Date argument non-optional for the onChange prop ([#1622](deephaven/web-client-ui#1622)) ([9a960b3](deephaven/web-client-ui@9a960b3)), closes [#1601](deephaven/web-client-ui#1601)
* Fixing grid colors and grays ([#1621](deephaven/web-client-ui#1621)) ([9ab2b1e](deephaven/web-client-ui@9ab2b1e)), closes [#1572](deephaven/web-client-ui#1572)
* Infinite loop with grid rendering ([#1631](deephaven/web-client-ui#1631)) ([4875d2e](deephaven/web-client-ui@4875d2e)), closes [#1626](deephaven/web-client-ui#1626)
* Log figure errors, don't show infinite spinner ([#1614](deephaven/web-client-ui#1614)) ([75783d0](deephaven/web-client-ui@75783d0))
* non-contiguous table row selection background colour ([#1623](deephaven/web-client-ui#1623)) ([61d1a53](deephaven/web-client-ui@61d1a53)), closes [#1619](deephaven/web-client-ui#1619)
* Panels not reinitializing if makeModel changes ([#1633](deephaven/web-client-ui#1633)) ([5ee98cd](deephaven/web-client-ui@5ee98cd))
* remove unecessary dom re-calc in grid render ([#1632](deephaven/web-client-ui#1632)) ([ce7cc3e](deephaven/web-client-ui@ce7cc3e))


### Features

* Add `LayoutManagerContext` and `useLayoutManager` ([#1625](deephaven/web-client-ui#1625)) ([0a6965a](deephaven/web-client-ui@0a6965a))
* Add ResizeObserver to Grid and Chart ([#1626](deephaven/web-client-ui#1626)) ([35311c8](deephaven/web-client-ui@35311c8))
* Added test:debug script ([#1628](deephaven/web-client-ui#1628)) ([80f29f5](deephaven/web-client-ui@80f29f5)), closes [#1627](deephaven/web-client-ui#1627)
* Read settings from props/server config when available ([#1558](deephaven/web-client-ui#1558)) ([52ba2cd](deephaven/web-client-ui@52ba2cd))
* Theming - Charts ([#1608](deephaven/web-client-ui#1608)) ([d5b3b48](deephaven/web-client-ui@d5b3b48)), closes [#1572](deephaven/web-client-ui#1572)


### BREAKING CHANGES

- ChartThemeProvider is now required to provide ChartTheme
- ChartModelFactory and ChartUtils now require chartTheme args

Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bmingles bmingles

Labels
enhancement New feature or request web-client-ui
Projects
None yet
Milestone
No milestone
2 participants
@bmingles @vbabich