Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type error in TableSaver.tsx #803

Closed
Zhou-Ziheng opened this issue Oct 7, 2022 · 0 comments · Fixed by #1186
Closed

Fix type error in TableSaver.tsx #803

Zhou-Ziheng opened this issue Oct 7, 2022 · 0 comments · Fixed by #1186
Assignees
@Zhou-Ziheng
Labels
bug Something isn't working
Milestone
March 2023

Comments

@Zhou-Ziheng
Copy link
Contributor

Description

The class variable this.WritableStream is incorrectly typed in TableSaver.tsx

Steps to reproduce

  1. Go to TableSaver.tsx
  2. Scroll down to WritableStream = window.WritableStream ?? ponyfillWritableStream;

Expected results

WritableStream should be typed as
WritableStream: window.WritableStream || ponyfillWritableStream;

Actual results

WritableStream is typed as
WritableStream = window.WritableStream ?? ponyfillWritableStream;
@Zhou-Ziheng Zhou-Ziheng added bug Something isn't working triage Issue requires triage labels Oct 7, 2022
@vbabich vbabich removed the triage Issue requires triage label Oct 12, 2022
@vbabich vbabich added this to the October 2022 milestone Oct 12, 2022
@mofojed mofojed modified the milestones: October 2022, November 2022 Nov 16, 2022
@mofojed mofojed modified the milestones: November 2022, December 2022 Dec 5, 2022
@mofojed mofojed modified the milestones: December 2022, January 2023 Dec 29, 2022
@mofojed mofojed modified the milestones: January 2023, February 2023 Feb 8, 2023
@mofojed mofojed modified the milestones: February 2023, March 2023 Mar 8, 2023
mofojed added a commit to mofojed/web-client-ui that referenced this issue Mar 29, 2023
@mofojed
fix: Typing for WritableStream
d4cee7a 
- Import in a different file and just export it
- Use implicit typing to work around the issue
- Fixes deephaven#803
@mofojed mofojed mentioned this issue Mar 29, 2023
Merged
mofojed added a commit that referenced this issue Mar 30, 2023
@mofojed
fix: Typing for WritableStream (#1186)
dfdf356 
- Import in a different file and just export it
- Use implicit typing to work around the issue
- Fixes #803
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Zhou-Ziheng Zhou-Ziheng

Labels
bug Something isn't working
Projects
None yet
Milestone
March 2023
Development

Successfully merging a pull request may close this issue.

fix: Typing for WritableStream mofojed/web-client-ui
3 participants
@vbabich @mofojed @Zhou-Ziheng