Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Typing for WritableStream #1186

Merged
merged 2 commits into from
Mar 30, 2023
Merged

fix: Typing for WritableStream #1186

merged 2 commits into from
Mar 30, 2023

Conversation

mofojed
Copy link
Member

@mofojed mofojed commented Mar 29, 2023

@mofojed
fix: Typing for WritableStream
d4cee7a 
- Import in a different file and just export it
- Use implicit typing to work around the issue
- Fixes deephaven#803
@mofojed mofojed requested a review from Zhou-Ziheng March 29, 2023 19:31
@mofojed mofojed self-assigned this Mar 29, 2023
@mofojed mofojed requested a review from dsmmcken March 29, 2023 21:19
@codecov
Copy link

codecov bot commented Mar 29, 2023 •
edited
Loading

Codecov Report

Merging #1186 (efdc312) into main (696cc2d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main    #1186      +/-   ##
==========================================
- Coverage   44.19%   44.18%   -0.01%     
==========================================
  Files         448      448              
  Lines       33310    33308       -2     
  Branches     8364     8362       -2     
==========================================
- Hits        14720    14718       -2     
  Misses      18541    18541              
  Partials       49       49
Flag Coverage Δ
unit 44.18% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/iris-grid/src/sidebar/TableSaver.tsx 11.78% <0.00%> (-0.56%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Zhou-Ziheng
Zhou-Ziheng approved these changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@Zhou-Ziheng Zhou-Ziheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mofojed mofojed merged commit dfdf356 into deephaven:main Mar 30, 2023
@mofojed mofojed deleted the 803-table-saver-type branch March 30, 2023 21:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Zhou-Ziheng Zhou-Ziheng Zhou-Ziheng approved these changes

@dsmmcken dsmmcken dsmmcken approved these changes

Assignees

@mofojed mofojed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix type error in TableSaver.tsx
3 participants
@mofojed @dsmmcken @Zhou-Ziheng