Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Copy Cell Unformatted" on a datetime column should provide a complete datetime #919

Closed
mofojed opened this issue Nov 30, 2022 · 0 comments · Fixed by #920
Closed

"Copy Cell Unformatted" on a datetime column should provide a complete datetime #919

mofojed opened this issue Nov 30, 2022 · 0 comments · Fixed by #920
Assignees
@mofojed
Labels
enhancement New feature or request
Milestone
November 2022

Comments

@mofojed
Copy link
Member

mofojed commented Nov 30, 2022 •
edited
Loading

Pulled from #614.

"Copy Cell Unformatted" on a datetime column should provide a complete datetime (e.g. 2022-06-14T15:08:13.000000000 <zone>), instead of the time offset in nanoseconds. The time offset in nanoseconds is fairly useless.
@mofojed mofojed added enhancement New feature or request triage Issue requires triage labels Nov 30, 2022
@mofojed mofojed self-assigned this Nov 30, 2022
@mofojed mofojed removed the triage Issue requires triage label Nov 30, 2022
@mofojed mofojed added this to the November 2022 milestone Nov 30, 2022
@mofojed mofojed mentioned this issue Nov 30, 2022
Closed
mofojed added a commit to mofojed/web-client-ui that referenced this issue Nov 30, 2022
@mofojed
Copy unformatted cell for dates should copy full date string
bdc677e 
- Instead of copying the numeric value in nanoseconds of the date, copy it as a full date string
- Tested with a date column, changing time zones, and copying values. The date was correct and time zone was included correctly. Also tested non-date columns still copied as intended.
- Fixes deephaven#919
@mofojed mofojed mentioned this issue Nov 30, 2022
Merged
mofojed added a commit that referenced this issue Dec 2, 2022
@mofojed
Copy unformatted cell for dates should copy full date string (#920)
3a93308 
- Instead of copying the numeric value in nanoseconds of the date, copy it as a full date string with 'T' separator
- Tested with a date column, changing time zones, and copying values. The date was correct and time zone was included correctly. Also tested non-date columns still copied as intended.
- Fixes #919
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mofojed mofojed

Labels
enhancement New feature or request
Projects
None yet
Milestone
November 2022
Development

Successfully merging a pull request may close this issue.

Copy unformatted cell for dates should copy full date string mofojed/web-client-ui
1 participant
@mofojed