Copy unformatted cell for dates should copy full date string #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
mofojed
commented
Nov 30, 2022
mofojed
commented
- Instead of copying the numeric value in nanoseconds of the date, copy it as a full date string
- Tested with a date column, changing time zones, and copying values. The date was correct and time zone was included correctly. Also tested non-date columns still copied as intended.
- Fixes "Copy Cell Unformatted" on a datetime column should provide a complete datetime #919
- Instead of copying the numeric value in nanoseconds of the date, copy it as a full date string - Tested with a date column, changing time zones, and copying values. The date was correct and time zone was included correctly. Also tested non-date columns still copied as intended. - Fixes deephaven#919
Codecov Report
@@ Coverage Diff @@
## main #920 +/- ##
==========================================
- Coverage 37.72% 37.71% -0.01%
==========================================
Files 410 410
Lines 31104 31109 +5
Branches 7752 7753 +1
==========================================
+ Hits 11733 11734 +1
- Misses 19316 19320 +4
Partials 55 55
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
dsmmcken
requested changes
Dec 1, 2022
dsmmcken
approved these changes
Dec 2, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.