Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stuck to bottom on filter clear #1579

Merged
merged 7 commits into from
Oct 27, 2023

remove commented code

e42f72b
Select commit
Loading
Failed to load commit list.
Merged

fix: stuck to bottom on filter clear #1579

remove commented code
e42f72b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 27, 2023 in 0s

46.74% (+0.26%) compared to 4eda17c

View this Pull Request on Codecov

46.74% (+0.26%) compared to 4eda17c

Details

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4eda17c) 46.48% compared to head (e42f72b) 46.74%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1579      +/-   ##
==========================================
+ Coverage   46.48%   46.74%   +0.26%     
==========================================
  Files         571      583      +12     
  Lines       36011    36262     +251     
  Branches     9012     9072      +60     
==========================================
+ Hits        16738    16951     +213     
- Misses      19221    19259      +38     
  Partials       52       52              
Files Coverage Δ
packages/grid/src/Grid.tsx 64.43% <87.50%> (-0.07%) ⬇️
...kages/grid/src/key-handlers/SelectionKeyHandler.ts 67.59% <75.00%> (+0.36%) ⬆️

... and 70 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.