Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Tables that have names starting with underscore do not auto-launch from console #1656

Merged
merged 3 commits into from
Nov 30, 2023

Conversation

georgecwan
Copy link
Contributor

@georgecwan georgecwan commented Nov 23, 2023

Testing Instructions:

  1. Run the following code with the "Auto Launch Panels" option checked:
    from deephaven import empty_table
    
    t = empty_table(10).update("x=i")
    _t = empty_table(10).update("x=i")
  2. Table t should open automatically but table _t should remain closed
  3. Clicking on the button for _t should open it normally
  4. Run _t = empty_table(10).update("x=i+10"). This should update the values in _t if it is open
    • Nothing should happen if _t is closed.

BREAKING CHANGE: Tables assigned to variable beginning with "_" will not open automatically even if "Auto Launch Panels" is checked.

@georgecwan georgecwan requested a review from mofojed November 23, 2023 21:51
@georgecwan georgecwan self-assigned this Nov 23, 2023
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 16 lines in your changes are missing coverage. Please review.

Comparison is base (6083173) 46.58% compared to head (197319a) 46.61%.
Report is 5 commits behind head on main.

Files Patch % Lines
...dashboard-core-plugins/src/panels/ConsolePanel.tsx 8.33% 11 Missing ⚠️
packages/console/src/Console.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1656      +/-   ##
==========================================
+ Coverage   46.58%   46.61%   +0.02%     
==========================================
  Files         597      597              
  Lines       36525    36631     +106     
  Branches     9144     9181      +37     
==========================================
+ Hits        17015    17074      +59     
- Misses      19458    19505      +47     
  Partials       52       52              
Flag Coverage Δ
unit 46.61% <5.88%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgecwan georgecwan marked this pull request as ready for review November 23, 2023 22:12
@georgecwan georgecwan marked this pull request as draft November 24, 2023 19:49
@georgecwan georgecwan force-pushed the 1549-underscore-table branch 2 times, most recently from 23f998d to 6937496 Compare November 24, 2023 20:00
@georgecwan georgecwan force-pushed the 1549-underscore-table branch from 6937496 to 2bb3570 Compare November 24, 2023 20:18
@georgecwan georgecwan marked this pull request as ready for review November 24, 2023 21:34
packages/console/src/Console.tsx Outdated Show resolved Hide resolved
packages/console/src/Console.tsx Outdated Show resolved Hide resolved
@mofojed mofojed linked an issue Nov 27, 2023 that may be closed by this pull request
@georgecwan georgecwan merged commit 21131fe into deephaven:main Nov 30, 2023
6 checks passed
@georgecwan georgecwan deleted the 1549-underscore-table branch November 30, 2023 18:16
@github-actions github-actions bot locked and limited conversation to collaborators Nov 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants