-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI sometimes shows an incorrect "old" version of a table #1410
Comments
georgecwan
added a commit
that referenced
this issue
Nov 30, 2023
…nch from console (#1656) - Creating a table with a name that begins with an underscore will not open it regardless of whether "Auto Launch Panels" is checked - Closes #1549 - Fixes a bug where tables will not update if its variable is reassigned while "Auto Launch Panels" is unchecked - Closes #1410 ### Testing Instructions: 1. Run the following code with the "Auto Launch Panels" option checked: ```py from deephaven import empty_table t = empty_table(10).update("x=i") _t = empty_table(10).update("x=i") ``` 2. Table `t` should open automatically but table `_t` should remain closed 3. Clicking on the button for `_t` should open it normally 4. Run `_t = empty_table(10).update("x=i+10")`. This should update the values in `_t` if it is open - Nothing should happen if `_t` is closed. BREAKING CHANGE: Tables assigned to variable beginning with "_" will not open automatically even if "Auto Launch Panels" is checked.
mofojed
pushed a commit
to deephaven/deephaven-core
that referenced
this issue
Dec 11, 2023
Release notes https://github.com/deephaven/web-client-ui/releases/tag/v0.56.0 # [0.56.0](deephaven/web-client-ui@v0.55.0...v0.56.0) (2023-12-11) ### Bug Fixes * add right margin to <Button kind='inline'/> using icons ([#1664](deephaven/web-client-ui#1664)) ([fd8a6c6](deephaven/web-client-ui@fd8a6c6)) * adjust filter bar colour ([#1666](deephaven/web-client-ui#1666)) ([4c0200e](deephaven/web-client-ui@4c0200e)) * convert organize columns component to purecomponent ([#1653](deephaven/web-client-ui#1653)) ([8ddc114](deephaven/web-client-ui@8ddc114)), closes [#1650](deephaven/web-client-ui#1650) * Default to `Skip` operation instead of `Sum` operation ([#1648](deephaven/web-client-ui#1648)) ([6083173](deephaven/web-client-ui@6083173)), closes [#1355](deephaven/web-client-ui#1355) [#1355](deephaven/web-client-ui#1355) * Fix button snapshots ([#1655](deephaven/web-client-ui#1655)) ([c0cc966](deephaven/web-client-ui@c0cc966)) * popper blur in styleguide ([#1672](deephaven/web-client-ui#1672)) ([6fa2204](deephaven/web-client-ui@6fa2204)) * Unable to delete selected rows in some input tables ([#1678](deephaven/web-client-ui#1678)) ([1e71550](deephaven/web-client-ui@1e71550)), closes [#1677](deephaven/web-client-ui#1677) ### Features * Add embed-widget ([#1668](deephaven/web-client-ui#1668)) ([1b06675](deephaven/web-client-ui@1b06675)), closes [#1629](deephaven/web-client-ui#1629) * forward and back button for organize column search ([#1641](deephaven/web-client-ui#1641)) ([89f2be5](deephaven/web-client-ui@89f2be5)), closes [#1529](deephaven/web-client-ui#1529) * Tables that have names starting with underscore do not auto-launch from console ([#1656](deephaven/web-client-ui#1656)) ([21131fe](deephaven/web-client-ui@21131fe)), closes [#1549](deephaven/web-client-ui#1549) [#1410](deephaven/web-client-ui#1410) * theme fontawesome icon size wrapped in spectrum icons ([#1658](deephaven/web-client-ui#1658)) ([2aa8cef](deephaven/web-client-ui@2aa8cef)) * Theme Selector ([#1661](deephaven/web-client-ui#1661)) ([5e2be64](deephaven/web-client-ui@5e2be64)), closes [#1660](deephaven/web-client-ui#1660) * Theming - Bootstrap ([#1603](deephaven/web-client-ui#1603)) ([88bcae0](deephaven/web-client-ui@88bcae0)) * Theming - Inline svgs ([#1651](deephaven/web-client-ui#1651)) ([1e40d3e](deephaven/web-client-ui@1e40d3e)) * View cell contents in context menu ([#1657](deephaven/web-client-ui#1657)) ([90b7517](deephaven/web-client-ui@90b7517)), closes [#1605](deephaven/web-client-ui#1605) ### BREAKING CHANGES * Bootstrap color variables are now predominantly hsl based. SCSS will need to be updated accordingly. Theme providers are needed to load themes. * Tables assigned to variable beginning with "_" will not open automatically even if "Auto Launch Panels" is checked. Co-authored-by: deephaven-internal <deephaven-internal@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Sometimes, when working on queries in a code studio, it's possible to wind up in a state where a UI panel is incorrectly pointing to an old version of a table that used the same variable name.
For example, in the screenshot below, if you look at
t5
on the left (the old/bad version oft5
) vs. thet5
on the right (the new/good version oft5
), you can clearly see from the "ModTime2" column that they are actually different tables.This is with Version 1.20230511.106 (29a6afd7).
Here is an easy way to reproduce this:
t = db.i("DbInternal", "ProcessEventLog").where().sort("Timestamp")
)t
button):t = db.i("DbInternal", "QueryPerformanceLog").where()
)t
: . (The one on the left is wrong; it should have updated to show the QuryPerformanceLog.)The text was updated successfully, but these errors were encountered: