Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truncated-Normal Operation #1015

Merged
merged 4 commits into from
Jun 12, 2021
Merged

Truncated-Normal Operation #1015

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30b03f4
[tensoflow] Add truncated normal operation
AzizZayed Jun 9, 2021
a8a1a9b
Merge Truncated-Normal branch
AzizZayed Jun 10, 2021
fccdc01
Add truncated-normal to all engines that do not support it
AzizZayed Jun 11, 2021
2b1c526
Truncated-Normal Operation
AzizZayed Jun 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion api/src/main/java/ai/djl/ndarray/BaseNDManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
import ai.djl.ndarray.types.DataType;
import ai.djl.ndarray.types.Shape;
import ai.djl.util.PairList;
import ai.djl.util.RandomUtils;
import java.nio.Buffer;
import java.nio.file.Path;
import java.util.UUID;
Expand Down Expand Up @@ -156,7 +157,19 @@ public NDArray randomNormal(float loc, float scale, Shape shape, DataType dataTy
/** {@inheritDoc} */
@Override
public NDArray truncatedNormal(float loc, float scale, Shape shape, DataType dataType) {
throw new UnsupportedOperationException("Not supported!");
int sampleSize = (int) shape.size();
double[] dist = new double[sampleSize];

for (int i = 0; i < sampleSize; i++) {
double sample = RandomUtils.nextGaussian();
while (sample < -2 || sample > 2) {
sample = RandomUtils.nextGaussian();
}

dist[i] = sample;
}

return create(dist).addi(loc).muli(scale).reshape(shape).toType(dataType, false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AzizZayed I think you need to multiply before you add. Otherwise, it will scale the addition too.

}

/** {@inheritDoc} */
Expand Down